Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2551)

Unified Diff: build/toolchain/android/BUILD.gn

Issue 1236503002: GN: Use lib.unstripped rather than lib.stripped. Add a toolchain.gni (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@gn15
Patch Set: add comment Created 5 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « build/config/gcc/BUILD.gn ('k') | build/toolchain/gcc_toolchain.gni » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: build/toolchain/android/BUILD.gn
diff --git a/build/toolchain/android/BUILD.gn b/build/toolchain/android/BUILD.gn
index 867fa4897a51c1bdc464e5b704ab74a74ce1b97b..ed7c407ce0f65ae759aad7c1d097e5f8e8622c21 100644
--- a/build/toolchain/android/BUILD.gn
+++ b/build/toolchain/android/BUILD.gn
@@ -64,32 +64,10 @@ template("android_gcc_toolchain") {
ld = cxx
readelf = compiler_prefix + tool_prefix + "readelf"
nm = compiler_prefix + tool_prefix + "nm"
+ strip = "${tool_prefix}strip"
toolchain_os = "android"
toolchain_cpu = invoker.toolchain_cpu
-
- # We make the assumption that the gcc_toolchain will produce a soname with
- # the following definition.
- soname = "{{target_output_name}}{{output_extension}}"
-
- stripped_soname = "lib.stripped/${soname}"
- temp_stripped_soname = "${stripped_soname}.tmp"
-
- android_strip = "${tool_prefix}strip"
-
- strip_command =
- "$android_strip --strip-unneeded -o $temp_stripped_soname $soname"
- replace_command = "if ! cmp -s $temp_stripped_soname $stripped_soname; then mv $temp_stripped_soname $stripped_soname; fi"
- postsolink = "$strip_command && $replace_command"
- solink_outputs = [ stripped_soname ]
- default_output_extension = android_product_extension
-
- # We make the assumption that the gcc_toolchain will produce an exe with
- # the following definition.
- exe = "{{root_out_dir}}/{{target_output_name}}{{output_extension}}"
- stripped_exe = "exe.stripped/$exe"
- postlink = "$android_strip --strip-unneeded -o $stripped_exe $exe"
- link_outputs = [ stripped_exe ]
}
}
« no previous file with comments | « build/config/gcc/BUILD.gn ('k') | build/toolchain/gcc_toolchain.gni » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698