build/toolchain/win/BUILD.gn - Issue 1236503002: GN: Use lib.unstripped rather than lib.stripped. Add a toolchain.gni

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: build/toolchain/win/BUILD.gn

Issue 1236503002: GN: Use lib.unstripped rather than lib.stripped. Add a toolchain.gni (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@gn15

Patch Set: forgot to add toolchain.gni Created 5 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: build/toolchain/win/BUILD.gn

diff --git a/build/toolchain/win/BUILD.gn b/build/toolchain/win/BUILD.gn

index 34198e83519bcf73c5227db1e8012a7d3e0dae6d..7ee7d8304e6d137f79a1627a30308d00dc46f355 100644

--- a/build/toolchain/win/BUILD.gn

+++ b/build/toolchain/win/BUILD.gn

@@ -143,8 +143,7 @@ template("msvc_toolchain") {

tool("solink") {

dllname = "{{root_out_dir}}/{{target_output_name}}{{output_extension}}" # e.g. foo.dll

- libname =

- "{{root_out_dir}}/{{target_output_name}}{{output_extension}}.lib" # e.g. foo.dll.lib

+ libname = "${dllname}.lib" # e.g. foo.dll.lib

rspfile = "${dllname}.rsp"

link_command = "$python_path gyp-win-tool link-wrapper $env False link.exe /nologo /IMPLIB:$libname /DLL /OUT:$dllname /PDB:${dllname}.pdb @$rspfile"

« build/toolchain/toolchain.gni ('K') | « build/toolchain/toolchain.gni ('k') | components/resource_provider/BUILD.gn » ('j') | no next file with comments »