Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(150)

Unified Diff: extensions/shell/browser/shell_extensions_browser_client.cc

Issue 1236493004: Final batch adding real histogram values for extension events. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: android compile Created 5 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « extensions/shell/browser/shell_extensions_browser_client.h ('k') | tools/metrics/histograms/histograms.xml » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: extensions/shell/browser/shell_extensions_browser_client.cc
diff --git a/extensions/shell/browser/shell_extensions_browser_client.cc b/extensions/shell/browser/shell_extensions_browser_client.cc
index 7a14a9363380246616a09ff7cd3edff4575f8351..df0f872415f5ea9f593eedfcbc9203ce34d57e6f 100644
--- a/extensions/shell/browser/shell_extensions_browser_client.cc
+++ b/extensions/shell/browser/shell_extensions_browser_client.cc
@@ -202,20 +202,19 @@ ShellExtensionsBrowserClient::GetComponentExtensionResourceManager() {
}
void ShellExtensionsBrowserClient::BroadcastEventToRenderers(
+ events::HistogramValue histogram_value,
const std::string& event_name,
scoped_ptr<base::ListValue> args) {
if (!BrowserThread::CurrentlyOn(BrowserThread::UI)) {
BrowserThread::PostTask(
- BrowserThread::UI,
- FROM_HERE,
+ BrowserThread::UI, FROM_HERE,
base::Bind(&ShellExtensionsBrowserClient::BroadcastEventToRenderers,
- base::Unretained(this),
- event_name,
+ base::Unretained(this), histogram_value, event_name,
base::Passed(&args)));
return;
}
- scoped_ptr<Event> event(new Event(events::UNKNOWN, event_name, args.Pass()));
+ scoped_ptr<Event> event(new Event(histogram_value, event_name, args.Pass()));
EventRouter::Get(browser_context_)->BroadcastEvent(event.Pass());
}
« no previous file with comments | « extensions/shell/browser/shell_extensions_browser_client.h ('k') | tools/metrics/histograms/histograms.xml » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698