Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(245)

Unified Diff: extensions/browser/api/management/management_api.cc

Issue 1236493004: Final batch adding real histogram values for extension events. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: android compile Created 5 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: extensions/browser/api/management/management_api.cc
diff --git a/extensions/browser/api/management/management_api.cc b/extensions/browser/api/management/management_api.cc
index 1581414dd312425924563f5f80b3542f34743310..c2202c804455c3eba7d2da005a7fc56c0d016d98 100644
--- a/extensions/browser/api/management/management_api.cc
+++ b/extensions/browser/api/management/management_api.cc
@@ -832,32 +832,38 @@ ManagementEventRouter::~ManagementEventRouter() {
void ManagementEventRouter::OnExtensionLoaded(
content::BrowserContext* browser_context,
const Extension* extension) {
- BroadcastEvent(extension, management::OnEnabled::kEventName);
+ BroadcastEvent(extension, events::MANAGEMENT_ON_ENABLED,
+ management::OnEnabled::kEventName);
}
void ManagementEventRouter::OnExtensionUnloaded(
content::BrowserContext* browser_context,
const Extension* extension,
UnloadedExtensionInfo::Reason reason) {
- BroadcastEvent(extension, management::OnDisabled::kEventName);
+ BroadcastEvent(extension, events::MANAGEMENT_ON_DISABLED,
+ management::OnDisabled::kEventName);
}
void ManagementEventRouter::OnExtensionInstalled(
content::BrowserContext* browser_context,
const Extension* extension,
bool is_update) {
- BroadcastEvent(extension, management::OnInstalled::kEventName);
+ BroadcastEvent(extension, events::MANAGEMENT_ON_INSTALLED,
+ management::OnInstalled::kEventName);
}
void ManagementEventRouter::OnExtensionUninstalled(
content::BrowserContext* browser_context,
const Extension* extension,
extensions::UninstallReason reason) {
- BroadcastEvent(extension, management::OnUninstalled::kEventName);
+ BroadcastEvent(extension, events::MANAGEMENT_ON_UNINSTALLED,
+ management::OnUninstalled::kEventName);
}
-void ManagementEventRouter::BroadcastEvent(const Extension* extension,
- const char* event_name) {
+void ManagementEventRouter::BroadcastEvent(
+ const Extension* extension,
+ events::HistogramValue histogram_value,
+ const char* event_name) {
if (ShouldNotBeVisible(extension, browser_context_))
return; // Don't dispatch events for built-in extenions.
scoped_ptr<base::ListValue> args(new base::ListValue());
@@ -871,7 +877,7 @@ void ManagementEventRouter::BroadcastEvent(const Extension* extension,
EventRouter::Get(browser_context_)
->BroadcastEvent(scoped_ptr<Event>(
- new Event(events::UNKNOWN, event_name, args.Pass())));
+ new Event(histogram_value, event_name, args.Pass())));
}
ManagementAPI::ManagementAPI(content::BrowserContext* context)
« no previous file with comments | « extensions/browser/api/management/management_api.h ('k') | extensions/browser/api/system_info/system_info_api.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698