Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3269)

Unified Diff: chrome/browser/extensions/api/sync_file_system/extension_sync_event_observer.cc

Issue 1236493004: Final batch adding real histogram values for extension events. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: android compile Created 5 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/extensions/api/sync_file_system/extension_sync_event_observer.cc
diff --git a/chrome/browser/extensions/api/sync_file_system/extension_sync_event_observer.cc b/chrome/browser/extensions/api/sync_file_system/extension_sync_event_observer.cc
index c9caeed77ca241676cd8621016855ff7a09f1fd0..3b0dca5f94797f4b9f807c0bc65fa37b537bea6b 100644
--- a/chrome/browser/extensions/api/sync_file_system/extension_sync_event_observer.cc
+++ b/chrome/browser/extensions/api/sync_file_system/extension_sync_event_observer.cc
@@ -79,9 +79,8 @@ void ExtensionSyncEventObserver::OnSyncStateUpdated(
api::sync_file_system::OnServiceStatusChanged::Create(service_info));
BroadcastOrDispatchEvent(
- app_origin,
- api::sync_file_system::OnServiceStatusChanged::kEventName,
- params.Pass());
+ app_origin, events::SYNC_FILE_SYSTEM_ON_SERVICE_STATUS_CHANGED,
+ api::sync_file_system::OnServiceStatusChanged::kEventName, params.Pass());
}
void ExtensionSyncEventObserver::OnFileSynced(
@@ -110,13 +109,13 @@ void ExtensionSyncEventObserver::OnFileSynced(
params->AppendString(api::sync_file_system::ToString(direction_enum));
BroadcastOrDispatchEvent(
- url.origin(),
- api::sync_file_system::OnFileStatusChanged::kEventName,
- params.Pass());
+ url.origin(), events::SYNC_FILE_SYSTEM_ON_FILE_STATUS_CHANGED,
+ api::sync_file_system::OnFileStatusChanged::kEventName, params.Pass());
}
void ExtensionSyncEventObserver::BroadcastOrDispatchEvent(
const GURL& app_origin,
+ events::HistogramValue histogram_value,
const std::string& event_name,
scoped_ptr<base::ListValue> values) {
// Check to see whether the event should be broadcasted to all listening
@@ -126,7 +125,7 @@ void ExtensionSyncEventObserver::BroadcastOrDispatchEvent(
DCHECK(event_router);
scoped_ptr<Event> event(
- new Event(events::UNKNOWN, event_name, values.Pass()));
+ new Event(histogram_value, event_name, values.Pass()));
event->restrict_to_browser_context = browser_context_;
// No app_origin, broadcast to all listening extensions for this event name.

Powered by Google App Engine
This is Rietveld 408576698