chrome/browser/extensions/api/proxy/proxy_api.cc - Issue 1236493004: Final batch adding real histogram values for extension events.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/api/proxy/proxy_api.cc

Issue 1236493004: Final batch adding real histogram values for extension events. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: android compile Created 5 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/extensions/api/processes/processes_api.cc ('k') | chrome/browser/extensions/api/sync_file_system/extension_sync_event_observer.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/extensions/api/proxy/proxy_api.cc

diff --git a/chrome/browser/extensions/api/proxy/proxy_api.cc b/chrome/browser/extensions/api/proxy/proxy_api.cc

index bbc2248320672a81bf0215568d2256faf2aa61e0..33a7a9e4fa9aae20acab15ff7606a0bdbeac4e75 100644

--- a/chrome/browser/extensions/api/proxy/proxy_api.cc

+++ b/chrome/browser/extensions/api/proxy/proxy_api.cc

@@ -45,11 +45,13 @@ void ProxyEventRouter::OnProxyError(

args->Append(dict);

if (profile) {

- event_router->DispatchEventToRenderers(

- keys::kProxyEventOnProxyError, args.Pass(), profile, true, GURL());

+ event_router->DispatchEventToRenderers(events::PROXY_ON_PROXY_ERROR,

+ keys::kProxyEventOnProxyError,

+ args.Pass(), profile, true, GURL());

} else {

- event_router->BroadcastEventToRenderers(

- keys::kProxyEventOnProxyError, args.Pass(), GURL());

+ event_router->BroadcastEventToRenderers(events::PROXY_ON_PROXY_ERROR,

+ keys::kProxyEventOnProxyError,

+ args.Pass(), GURL());

}

@@ -75,11 +77,13 @@ void ProxyEventRouter::OnPACScriptError(

args->Append(dict);

if (profile) {

- event_router->DispatchEventToRenderers(

- keys::kProxyEventOnProxyError, args.Pass(), profile, true, GURL());

+ event_router->DispatchEventToRenderers(events::PROXY_ON_PROXY_ERROR,

+ keys::kProxyEventOnProxyError,

+ args.Pass(), profile, true, GURL());

} else {

- event_router->BroadcastEventToRenderers(

- keys::kProxyEventOnProxyError, args.Pass(), GURL());

+ event_router->BroadcastEventToRenderers(events::PROXY_ON_PROXY_ERROR,

+ keys::kProxyEventOnProxyError,

+ args.Pass(), GURL());

}