Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(816)

Unified Diff: chrome/browser/extensions/api/preference/preference_helpers.cc

Issue 1236493004: Final batch adding real histogram values for extension events. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: android compile Created 5 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/extensions/api/preference/preference_helpers.cc
diff --git a/chrome/browser/extensions/api/preference/preference_helpers.cc b/chrome/browser/extensions/api/preference/preference_helpers.cc
index 7f78ddc0da39a2a9b5d381d659e9bb1408ce7822..7993e39ccef3e805c82762bf87c6f09f487f1bcb 100644
--- a/chrome/browser/extensions/api/preference/preference_helpers.cc
+++ b/chrome/browser/extensions/api/preference/preference_helpers.cc
@@ -82,13 +82,13 @@ const char* GetLevelOfControl(
return kControlledByOtherExtensions;
}
-void DispatchEventToExtensions(
- Profile* profile,
- const std::string& event_name,
- base::ListValue* args,
- APIPermission::ID permission,
- bool incognito,
- const std::string& browser_pref) {
+void DispatchEventToExtensions(Profile* profile,
+ events::HistogramValue histogram_value,
+ const std::string& event_name,
+ base::ListValue* args,
+ APIPermission::ID permission,
+ bool incognito,
+ const std::string& browser_pref) {
EventRouter* router = EventRouter::Get(profile);
if (!router || !router->HasEventListener(event_name))
return;
@@ -127,7 +127,7 @@ void DispatchEventToExtensions(
scoped_ptr<base::ListValue> args_copy(args->DeepCopy());
scoped_ptr<Event> event(
- new Event(events::UNKNOWN, event_name, args_copy.Pass()));
+ new Event(histogram_value, event_name, args_copy.Pass()));
event->restrict_to_browser_context = restrict_to_profile;
router->DispatchEventToExtension(extension->id(), event.Pass());
}
« no previous file with comments | « chrome/browser/extensions/api/preference/preference_helpers.h ('k') | chrome/browser/extensions/api/processes/processes_api.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698