Index: chrome/browser/extensions/api/preference/preference_api.cc |
diff --git a/chrome/browser/extensions/api/preference/preference_api.cc b/chrome/browser/extensions/api/preference/preference_api.cc |
index 0fd24541313eab8b642657ec0129cb0b2b30f6f3..ac80eb49dc6e367e9c629ccf8f2cc342deb12a10 100644 |
--- a/chrome/browser/extensions/api/preference/preference_api.cc |
+++ b/chrome/browser/extensions/api/preference/preference_api.cc |
@@ -380,11 +380,19 @@ void PreferenceEventRouter::OnPrefChanged(PrefService* pref_service, |
ep->HasIncognitoPrefValue(browser_pref)); |
} |
- helpers::DispatchEventToExtensions(profile_, |
- event_name, |
- &args, |
- permission, |
- incognito, |
+ // TODO(kalman): Have a histogram value for each pref type. |
+ // This isn't so important for the current use case of these |
+ // histograms, which is to track which event types are waking up event |
+ // pages, or which are delivered to persistent background pages. Simply |
+ // "a setting changed" is enough detail for that. However if we try to |
+ // use these histograms for any fine-grained logic (like removing the |
+ // string event name altogether), or if we discover this event is |
+ // firing a lot and want to understand that better, then this will need |
+ // to change. |
+ events::HistogramValue histogram_value = |
+ events::TYPES_CHROME_SETTING_ON_CHANGE; |
+ helpers::DispatchEventToExtensions(profile_, histogram_value, event_name, |
+ &args, permission, incognito, |
browser_pref); |
} |