Final batch adding real histogram values for extension events.

extensions/browser/api/management/management_api.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "extensions/browser/api/management/management_api.h"
 
 #include <string>
 #include <vector>
 
 #include "base/basictypes.h"
@@ skipping 814 matching lines @@
     : browser_context_(context), extension_registry_observer_(this) {
   extension_registry_observer_.Add(ExtensionRegistry::Get(browser_context_));
 }
 
 ManagementEventRouter::~ManagementEventRouter() {
 }
 
 void ManagementEventRouter::OnExtensionLoaded(
     content::BrowserContext* browser_context,
     const Extension* extension) {
-  BroadcastEvent(extension, management::OnEnabled::kEventName);
+  BroadcastEvent(extension, events::MANAGEMENT_ON_ENABLED,
+                 management::OnEnabled::kEventName);
 }
 
 void ManagementEventRouter::OnExtensionUnloaded(
     content::BrowserContext* browser_context,
     const Extension* extension,
     UnloadedExtensionInfo::Reason reason) {
-  BroadcastEvent(extension, management::OnDisabled::kEventName);
+  BroadcastEvent(extension, events::MANAGEMENT_ON_DISABLED,
+                 management::OnDisabled::kEventName);
 }
 
 void ManagementEventRouter::OnExtensionInstalled(
     content::BrowserContext* browser_context,
     const Extension* extension,
     bool is_update) {
-  BroadcastEvent(extension, management::OnInstalled::kEventName);
+  BroadcastEvent(extension, events::MANAGEMENT_ON_INSTALLED,
+                 management::OnInstalled::kEventName);
 }
 
 void ManagementEventRouter::OnExtensionUninstalled(
     content::BrowserContext* browser_context,
     const Extension* extension,
     extensions::UninstallReason reason) {
-  BroadcastEvent(extension, management::OnUninstalled::kEventName);
+  BroadcastEvent(extension, events::MANAGEMENT_ON_UNINSTALLED,
+                 management::OnUninstalled::kEventName);
 }
 
-void ManagementEventRouter::BroadcastEvent(const Extension* extension,
-                                           const char* event_name) {
+void ManagementEventRouter::BroadcastEvent(
+    const Extension* extension,
+    events::HistogramValue histogram_value,
+    const char* event_name) {
   if (ShouldNotBeVisible(extension, browser_context_))
     return;  // Don't dispatch events for built-in extenions.
   scoped_ptr<base::ListValue> args(new base::ListValue());
   if (event_name == management::OnUninstalled::kEventName) {
     args->Append(new base::StringValue(extension->id()));
   } else {
     scoped_ptr<management::ExtensionInfo> info =
         CreateExtensionInfo(*extension, browser_context_);
     args->Append(info->ToValue().release());
   }
 
   EventRouter::Get(browser_context_)
       ->BroadcastEvent(scoped_ptr<Event>(
-          new Event(events::UNKNOWN, event_name, args.Pass())));
+          new Event(histogram_value, event_name, args.Pass())));
 }
 
 ManagementAPI::ManagementAPI(content::BrowserContext* context)
     : browser_context_(context),
       delegate_(ExtensionsAPIClient::Get()->CreateManagementAPIDelegate()) {
   EventRouter* event_router = EventRouter::Get(browser_context_);
   event_router->RegisterObserver(this, management::OnInstalled::kEventName);
   event_router->RegisterObserver(this, management::OnUninstalled::kEventName);
   event_router->RegisterObserver(this, management::OnEnabled::kEventName);
   event_router->RegisterObserver(this, management::OnDisabled::kEventName);
@@ skipping 14 matching lines @@
 ManagementAPI::GetFactoryInstance() {
   return g_factory.Pointer();
 }
 
 void ManagementAPI::OnListenerAdded(const EventListenerInfo& details) {
   management_event_router_.reset(new ManagementEventRouter(browser_context_));
   EventRouter::Get(browser_context_)->UnregisterObserver(this);
 }
 
 }  // namespace extensions