Final batch adding real histogram values for extension events.

chrome/browser/extensions/api/sync_file_system/extension_sync_event_observer.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/extensions/api/sync_file_system/extension_sync_event_observer.h"
 
 #include "base/lazy_instance.h"
 #include "chrome/browser/extensions/api/sync_file_system/sync_file_system_api_helpers.h"
 #include "chrome/browser/sync_file_system/sync_event_observer.h"
 #include "chrome/browser/sync_file_system/sync_file_system_service.h"
@@ skipping 61 matching lines @@
     sync_file_system::SyncServiceState state,
     const std::string& description) {
   // Convert state and description into SyncState Object.
   api::sync_file_system::ServiceInfo service_info;
   service_info.state = SyncServiceStateToExtensionEnum(state);
   service_info.description = description;
   scoped_ptr<base::ListValue> params(
       api::sync_file_system::OnServiceStatusChanged::Create(service_info));
 
   BroadcastOrDispatchEvent(
-      app_origin,
-      api::sync_file_system::OnServiceStatusChanged::kEventName,
-      params.Pass());
+      app_origin, events::SYNC_FILE_SYSTEM_ON_SERVICE_STATUS_CHANGED,
+      api::sync_file_system::OnServiceStatusChanged::kEventName, params.Pass());
 }
 
 void ExtensionSyncEventObserver::OnFileSynced(
     const storage::FileSystemURL& url,
     sync_file_system::SyncFileType file_type,
     sync_file_system::SyncFileStatus status,
     sync_file_system::SyncAction action,
     sync_file_system::SyncDirection direction) {
   scoped_ptr<base::ListValue> params(new base::ListValue());
 
   scoped_ptr<base::DictionaryValue> entry(
       CreateDictionaryValueForFileSystemEntry(url, file_type));
   if (!entry)
     return;
   params->Append(entry.release());
 
   // Status, SyncAction and any optional notes to go here.
   api::sync_file_system::FileStatus status_enum =
       SyncFileStatusToExtensionEnum(status);
   api::sync_file_system::SyncAction action_enum =
       SyncActionToExtensionEnum(action);
   api::sync_file_system::SyncDirection direction_enum =
       SyncDirectionToExtensionEnum(direction);
   params->AppendString(api::sync_file_system::ToString(status_enum));
   params->AppendString(api::sync_file_system::ToString(action_enum));
   params->AppendString(api::sync_file_system::ToString(direction_enum));
 
   BroadcastOrDispatchEvent(
-      url.origin(),
-      api::sync_file_system::OnFileStatusChanged::kEventName,
-      params.Pass());
+      url.origin(), events::SYNC_FILE_SYSTEM_ON_FILE_STATUS_CHANGED,
+      api::sync_file_system::OnFileStatusChanged::kEventName, params.Pass());
 }
 
 void ExtensionSyncEventObserver::BroadcastOrDispatchEvent(
     const GURL& app_origin,
+    events::HistogramValue histogram_value,
     const std::string& event_name,
     scoped_ptr<base::ListValue> values) {
   // Check to see whether the event should be broadcasted to all listening
   // extensions or sent to a specific extension ID.
   bool broadcast_mode = app_origin.is_empty();
   EventRouter* event_router = EventRouter::Get(browser_context_);
   DCHECK(event_router);
 
   scoped_ptr<Event> event(
-      new Event(events::UNKNOWN, event_name, values.Pass()));
+      new Event(histogram_value, event_name, values.Pass()));
   event->restrict_to_browser_context = browser_context_;
 
   // No app_origin, broadcast to all listening extensions for this event name.
   if (broadcast_mode) {
     event_router->BroadcastEvent(event.Pass());
     return;
   }
 
   // Dispatch to single extension ID.
   const std::string extension_id = GetExtensionId(app_origin);
   if (extension_id.empty())
     return;
   event_router->DispatchEventToExtension(extension_id, event.Pass());
 }
 
 template <>
 void BrowserContextKeyedAPIFactory<
     ExtensionSyncEventObserver>::DeclareFactoryDependencies() {
   DependsOn(sync_file_system::SyncFileSystemServiceFactory::GetInstance());
   DependsOn(ExtensionsBrowserClient::Get()->GetExtensionSystemFactory());
 }
 
 }  // namespace extensions