Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(19)

Issue 1236493003: fix code coverage to work on dev channel (Closed)

Created:
5 years, 5 months ago by Jennifer Messerly
Modified:
5 years, 5 months ago
Reviewers:
vsm
CC:
dev-compiler+reviews_dartlang.org
Base URL:
git@github.com:dart-lang/dev_compiler.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M tool/coverage.sh View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 5 (1 generated)
Jennifer Messerly
5 years, 5 months ago (2015-07-17 16:55:59 UTC) #2
Jennifer Messerly
it works: https://coveralls.io/builds/3087284, https://coveralls.io/builds/3087320 :)
5 years, 5 months ago (2015-07-17 16:57:22 UTC) #3
vsm
lgtm!
5 years, 5 months ago (2015-07-17 17:09:58 UTC) #4
Jennifer Messerly
5 years, 5 months ago (2015-07-22 21:50:26 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
dd5912842d75a796f8b84c20788cf50c8990ca7b (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698