Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(465)

Issue 1236473005: Force IPv4 in adb_remote_setup.sh. (Closed)

Created:
5 years, 5 months ago by newt (away)
Modified:
5 years, 5 months ago
Reviewers:
nyquist
CC:
chromium-reviews, klundberg+watch_chromium.org, yfriedman+watch_chromium.org, jbudorick+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Force IPv4 in adb_remote_setup.sh. Port forwarding over IPv6 results in this failure: "bind: Cannot assign requested address", so force usage of IPv4. R=nyquist@chromium.org Committed: https://crrev.com/71232441f094202a478ee8380602ee045ec5403a Cr-Commit-Position: refs/heads/master@{#338394}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M tools/android/adb_remote_setup.sh View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 6 (1 generated)
newt (away)
5 years, 5 months ago (2015-07-10 21:00:05 UTC) #1
nyquist
lgtm
5 years, 5 months ago (2015-07-10 23:14:21 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1236473005/1
5 years, 5 months ago (2015-07-10 23:15:53 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 5 months ago (2015-07-10 23:26:02 UTC) #5
commit-bot: I haz the power
5 years, 5 months ago (2015-07-10 23:27:05 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/71232441f094202a478ee8380602ee045ec5403a
Cr-Commit-Position: refs/heads/master@{#338394}

Powered by Google App Engine
This is Rietveld 408576698