Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1949)

Unified Diff: third_party/libphonenumber/BUILD.gn

Issue 1236443005: win/clang: Suppress another -Wunused-private-field warning. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | third_party/libphonenumber/libphonenumber.gyp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/libphonenumber/BUILD.gn
diff --git a/third_party/libphonenumber/BUILD.gn b/third_party/libphonenumber/BUILD.gn
index 832cc06dcb6b7ab89fea542fbec1975ef952d719..edd808a66d741d87e43a68671c0b84bc35de18e7 100644
--- a/third_party/libphonenumber/BUILD.gn
+++ b/third_party/libphonenumber/BUILD.gn
@@ -24,6 +24,15 @@ config("libphonenumber_config") {
}
}
+config("libphonenumber_config_internal") {
+ if (is_clang) {
+ cflags = [
+ # https://github.com/googlei18n/libphonenumber/pull/741
+ "-Wno-unused-private-field",
+ ]
+ }
+}
+
# GYP version: third_party/libphonenumber/libphonenumber.gyp:libphonenumber_without_metadata
static_library("libphonenumber_without_metadata") {
sources = [
@@ -49,17 +58,10 @@ static_library("libphonenumber_without_metadata") {
# do not consume their arguments. This leads to unused variable warnings in
# release builds.
configs -= [ "//build/config/compiler:chromium_code" ]
- configs += [ "//build/config/compiler:no_chromium_code" ]
-
- config("libphonenumber_without_metadata_warnings") {
- if (is_clang) {
- cflags = [
- # https://github.com/googlei18n/libphonenumber/pull/741
- "-Wno-unused-private-field",
- ]
- }
- }
- configs += [ ":libphonenumber_without_metadata_warnings" ]
+ configs += [
+ "//build/config/compiler:no_chromium_code",
+ ":libphonenumber_config_internal",
+ ]
public_configs = [ ":libphonenumber_config" ]
@@ -102,6 +104,8 @@ test("libphonenumber_unittests") {
"src/test/phonenumbers/unicodestring_test.cc",
]
+ configs += [ ":libphonenumber_config_internal" ]
+
include_dirs = [ "src/test" ]
deps = [
« no previous file with comments | « no previous file | third_party/libphonenumber/libphonenumber.gyp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698