Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(27)

Side by Side Diff: third_party/libphonenumber/libphonenumber.gyp

Issue 1236443005: win/clang: Suppress another -Wunused-private-field warning. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « third_party/libphonenumber/BUILD.gn ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 # Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 # Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 { 5 {
6 'target_defaults': { 6 'target_defaults': {
7 'include_dirs': [ 7 'include_dirs': [
8 'src', 8 'src',
9 'src/test', 9 'src/test',
10 # The libphonenumber source (and test code) expects the 10 # The libphonenumber source (and test code) expects the
(...skipping 120 matching lines...) Expand 10 before | Expand all | Expand 10 after
131 ], 131 ],
132 'dependencies': [ 132 'dependencies': [
133 '../icu/icu.gyp:icui18n', 133 '../icu/icu.gyp:icui18n',
134 '../icu/icu.gyp:icuuc', 134 '../icu/icu.gyp:icuuc',
135 '../../base/base.gyp:run_all_unittests', 135 '../../base/base.gyp:run_all_unittests',
136 '../../base/third_party/dynamic_annotations/dynamic_annotations.gyp:dynami c_annotations', 136 '../../base/third_party/dynamic_annotations/dynamic_annotations.gyp:dynami c_annotations',
137 '../../testing/gmock.gyp:gmock', 137 '../../testing/gmock.gyp:gmock',
138 '../../testing/gtest.gyp:gtest', 138 '../../testing/gtest.gyp:gtest',
139 'libphonenumber_without_metadata', 139 'libphonenumber_without_metadata',
140 ], 140 ],
141 'variables': {
142 'clang_warning_flags': [
143 # https://github.com/googlei18n/libphonenumber/pull/741
144 '-Wno-unused-private-field',
145 ],
146 },
141 'conditions': [ 147 'conditions': [
142 ['OS=="win"', { 148 ['OS=="win"', {
143 'action': [ 149 'action': [
144 '/wo4309', 150 '/wo4309',
145 ], 151 ],
146 }], 152 }],
147 # libphonenumber needs to fix their ODR violations. http://crbug.com/45602 1 153 # libphonenumber needs to fix their ODR violations. http://crbug.com/45602 1
148 ['OS=="linux"', { 154 ['OS=="linux"', {
149 'ldflags!': [ 155 'ldflags!': [
150 '-Wl,--detect-odr-violations', 156 '-Wl,--detect-odr-violations',
151 ], 157 ],
152 }], 158 }],
153 ], 159 ],
154 }] 160 }]
155 } 161 }
OLDNEW
« no previous file with comments | « third_party/libphonenumber/BUILD.gn ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698