Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(774)

Unified Diff: runtime/vm/handles.cc

Issue 1236403004: Migrate handle scope fields to Thread. (Closed) Base URL: git@github.com:dart-lang/sdk.git@master
Patch Set: Ready for review. Created 5 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « runtime/vm/handles.h ('k') | runtime/vm/handles_impl.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/vm/handles.cc
diff --git a/runtime/vm/handles.cc b/runtime/vm/handles.cc
index bd45c731369df723f4733bf35f1d0c64c20bfb58..f636fdd29171a1d6d6747da37717c655090f22c7 100644
--- a/runtime/vm/handles.cc
+++ b/runtime/vm/handles.cc
@@ -91,47 +91,57 @@ int VMHandles::ZoneHandleCount() {
}
-HandleScope::HandleScope(Isolate* isolate) : StackResource(isolate) {
- ASSERT(isolate->no_handle_scope_depth() == 0);
- VMHandles* handles = isolate->current_zone()->handles();
+void HandleScope::Initialize() {
+ ASSERT(thread()->no_handle_scope_depth() == 0);
+ VMHandles* handles = thread()->zone()->handles();
ASSERT(handles != NULL);
saved_handle_block_ = handles->scoped_blocks_;
saved_handle_slot_ = handles->scoped_blocks_->next_handle_slot();
#if defined(DEBUG)
- link_ = isolate->top_handle_scope();
- isolate->set_top_handle_scope(this);
+ link_ = thread()->top_handle_scope();
+ thread()->set_top_handle_scope(this);
#endif
}
+HandleScope::HandleScope(Thread* thread) : StackResource(thread) {
+ Initialize();
+}
+
+
+HandleScope::HandleScope(Isolate* isolate) : StackResource(isolate) {
+ Initialize();
+}
+
+
HandleScope::~HandleScope() {
- ASSERT(isolate()->current_zone() != NULL);
- VMHandles* handles = isolate()->current_zone()->handles();
+ ASSERT(thread()->zone() != NULL);
+ VMHandles* handles = thread()->zone()->handles();
ASSERT(handles != NULL);
handles->scoped_blocks_ = saved_handle_block_;
handles->scoped_blocks_->set_next_handle_slot(saved_handle_slot_);
#if defined(DEBUG)
handles->VerifyScopedHandleState();
handles->ZapFreeScopedHandles();
- ASSERT(isolate()->top_handle_scope() == this);
- isolate()->set_top_handle_scope(link_);
+ ASSERT(thread()->top_handle_scope() == this);
+ thread()->set_top_handle_scope(link_);
#endif
}
#if defined(DEBUG)
NoHandleScope::NoHandleScope(Isolate* isolate) : StackResource(isolate) {
- isolate->IncrementNoHandleScopeDepth();
+ thread()->IncrementNoHandleScopeDepth();
}
-NoHandleScope::NoHandleScope() : StackResource(Isolate::Current()) {
- isolate()->IncrementNoHandleScopeDepth();
+NoHandleScope::NoHandleScope() : StackResource(Thread::Current()) {
+ thread()->IncrementNoHandleScopeDepth();
}
NoHandleScope::~NoHandleScope() {
- isolate()->DecrementNoHandleScopeDepth();
+ thread()->DecrementNoHandleScopeDepth();
}
#endif // defined(DEBUG)
« no previous file with comments | « runtime/vm/handles.h ('k') | runtime/vm/handles_impl.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698