Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(560)

Unified Diff: runtime/vm/base_isolate.h

Issue 1236403004: Migrate handle scope fields to Thread. (Closed) Base URL: git@github.com:dart-lang/sdk.git@master
Patch Set: Ready for review. Created 5 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | runtime/vm/handles.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/vm/base_isolate.h
diff --git a/runtime/vm/base_isolate.h b/runtime/vm/base_isolate.h
index 1e92a22b787ce08eba027c017fa061e5a8f7f721..fc6de2b153e4c3711daf5ac40acb3a4c86e93760 100644
--- a/runtime/vm/base_isolate.h
+++ b/runtime/vm/base_isolate.h
@@ -26,42 +26,6 @@ class BaseIsolate {
void AssertCurrentThreadIsMutator() const {}
#endif // DEBUG
- HandleScope* top_handle_scope() const {
-#if defined(DEBUG)
- return top_handle_scope_;
-#else
- return 0;
-#endif
- }
-
- void set_top_handle_scope(HandleScope* handle_scope) {
-#if defined(DEBUG)
- top_handle_scope_ = handle_scope;
-#endif
- }
-
- int32_t no_handle_scope_depth() const {
-#if defined(DEBUG)
- return no_handle_scope_depth_;
-#else
- return 0;
-#endif
- }
-
- void IncrementNoHandleScopeDepth() {
-#if defined(DEBUG)
- ASSERT(no_handle_scope_depth_ < INT_MAX);
- no_handle_scope_depth_ += 1;
-#endif
- }
-
- void DecrementNoHandleScopeDepth() {
-#if defined(DEBUG)
- ASSERT(no_handle_scope_depth_ > 0);
- no_handle_scope_depth_ -= 1;
-#endif
- }
-
int32_t no_safepoint_scope_depth() const {
#if defined(DEBUG)
return no_safepoint_scope_depth_;
@@ -106,8 +70,6 @@ class BaseIsolate {
BaseIsolate()
: mutator_thread_(NULL),
#if defined(DEBUG)
- top_handle_scope_(NULL),
- no_handle_scope_depth_(0),
no_safepoint_scope_depth_(0),
#endif
no_callback_scope_depth_(0)
@@ -119,8 +81,6 @@ class BaseIsolate {
Thread* mutator_thread_;
#if defined(DEBUG)
- HandleScope* top_handle_scope_;
- int32_t no_handle_scope_depth_;
int32_t no_safepoint_scope_depth_;
#endif
int32_t no_callback_scope_depth_;
« no previous file with comments | « no previous file | runtime/vm/handles.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698