Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(27)

Issue 1236363002: ExtensionSyncService cleanup: process uninstalls in one step (Closed)

Created:
5 years, 5 months ago by Marc Treib
Modified:
5 years, 5 months ago
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

ExtensionSyncService cleanup: process uninstalls in one step Before, the process was split into PrepareToSyncUninstallExtension and ProcessSyncUninstallExtension for no good reason. BUG=None Committed: https://crrev.com/59ef2589e04cebc6d8a3c7d13c6b844b1362714b Cr-Commit-Position: refs/heads/master@{#339003}

Patch Set 1 #

Total comments: 2

Patch Set 2 : review #

Unified diffs Side-by-side diffs Delta from patch set Stats (+21 lines, -43 lines) Patch
M chrome/browser/extensions/extension_service.cc View 2 chunks +5 lines, -12 lines 0 comments Download
M chrome/browser/extensions/extension_sync_service.h View 1 chunk +1 line, -9 lines 0 comments Download
M chrome/browser/extensions/extension_sync_service.cc View 1 2 chunks +12 lines, -19 lines 0 comments Download
M chrome/browser/extensions/pending_enables.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/sync_bundle.h View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/sync_bundle.cc View 1 1 chunk +1 line, -1 line 0 comments Download

Dependent Patchsets:

Messages

Total messages: 11 (3 generated)
Marc Treib
Another small and (hopefully) uncontroversial cleanup before commencing with the bigger changes. PTAL!
5 years, 5 months ago (2015-07-15 11:33:28 UTC) #2
not at google - send to devlin
lgtm. I cannot figure out why this was split into 2 functions. The only reason ...
5 years, 5 months ago (2015-07-15 17:22:42 UTC) #3
not at google - send to devlin
Optional more cleanup which would be really nice: https://codereview.chromium.org/1236363002/diff/1/chrome/browser/extensions/extension_sync_service.cc File chrome/browser/extensions/extension_sync_service.cc (right): https://codereview.chromium.org/1236363002/diff/1/chrome/browser/extensions/extension_sync_service.cc#newcode134 chrome/browser/extensions/extension_sync_service.cc:134: bundle->PushSyncDeletion(id, ...
5 years, 5 months ago (2015-07-15 17:49:14 UTC) #4
Marc Treib
On 2015/07/15 17:22:42, kalman wrote: > lgtm. I cannot figure out why this was split ...
5 years, 5 months ago (2015-07-16 08:09:53 UTC) #5
Marc Treib
https://codereview.chromium.org/1236363002/diff/1/chrome/browser/extensions/extension_sync_service.cc File chrome/browser/extensions/extension_sync_service.cc (right): https://codereview.chromium.org/1236363002/diff/1/chrome/browser/extensions/extension_sync_service.cc#newcode134 chrome/browser/extensions/extension_sync_service.cc:134: bundle->PushSyncDeletion(id, CreateSyncData(extension).GetSyncData()); On 2015/07/15 17:49:13, kalman wrote: > Btw ...
5 years, 5 months ago (2015-07-16 08:12:29 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1236363002/20001
5 years, 5 months ago (2015-07-16 08:12:52 UTC) #9
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 5 months ago (2015-07-16 08:55:09 UTC) #10
commit-bot: I haz the power
5 years, 5 months ago (2015-07-16 08:56:04 UTC) #11
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/59ef2589e04cebc6d8a3c7d13c6b844b1362714b
Cr-Commit-Position: refs/heads/master@{#339003}

Powered by Google App Engine
This is Rietveld 408576698