Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(210)

Unified Diff: include/v8.h

Issue 1236263004: Deprecate unused Map/Set FromArray factory methods (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Created 5 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: include/v8.h
diff --git a/include/v8.h b/include/v8.h
index 560bfb4d00370d5edaf2ab34c4e4e8e8a7369ebf..92a1235e672a182600228124b94fe2d5a4204ae2 100644
--- a/include/v8.h
+++ b/include/v8.h
@@ -3008,8 +3008,9 @@ class V8_EXPORT Map : public Object {
* in the same manner as the array returned from AsArray().
* Guaranteed to be side-effect free if the array contains no holes.
*/
- static V8_WARN_UNUSED_RESULT MaybeLocal<Map> FromArray(Local<Context> context,
- Local<Array> array);
+ static V8_WARN_UNUSED_RESULT V8_DEPRECATE_SOON(
jochen (gone - plz use gerrit) 2015/07/15 13:35:37 can you mark them as V8_DEPRECATED() right away?
+ "Use mutation methods instead",
+ MaybeLocal<Map> FromArray(Local<Context> context, Local<Array> array));
V8_INLINE static Map* Cast(Value* obj);
@@ -3047,8 +3048,9 @@ class V8_EXPORT Set : public Object {
* Creates a new Set containing the items in array.
* Guaranteed to be side-effect free if the array contains no holes.
*/
- static V8_WARN_UNUSED_RESULT MaybeLocal<Set> FromArray(Local<Context> context,
- Local<Array> array);
+ static V8_WARN_UNUSED_RESULT V8_DEPRECATE_SOON(
+ "Use mutation methods instead",
+ MaybeLocal<Set> FromArray(Local<Context> context, Local<Array> array));
V8_INLINE static Set* Cast(Value* obj);
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698