Issue 1236243002: chromium-cq-status timeline view uses cname argument.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1236243002: chromium-cq-status timeline view uses cname argument. (Closed)

Created:
5 years, 5 months ago by Shi-Ke Xue

Modified:
5 years, 5 months ago

Reviewers:
ghost stip (do not use)

CC:
chromium-reviews

Base URL:
https://chromium.googlesource.com/infra/infra.git@master

Target Ref:
refs/heads/master

Project:
infra

Visibility:
Public.

More Reviews

Description

chromium-cq-status timeline view uses cname argument. Trace Viewer was modified with support for custom colors using a 'cname' argument. This CL modifies the data endpoint for CQ Trace Viewer to use this new argument to set the colors. Another small change - the get_attempts method returns a generator instead of a list instead. BUG=510162 R=stip@chromium.org Committed: https://chromium.googlesource.com/infra/infra/+/7b36f623e12a4b76efb54715dbe96acab71aab63

Patch Set 1 #

Created: 5 years, 5 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+29 lines, -34 lines)			Patch
	M	appengine/chromium_cq_status/handlers/patch_timeline_data.py	View		6 chunks	+20 lines, -23 lines	0 comments	Download
	M	appengine/chromium_cq_status/tests/patch_timeline_data_test.py	View		6 chunks	+9 lines, -11 lines	0 comments	Download

Messages

Total messages: 6 (1 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

ghost stip (do not use)

lgtm. this doesn't use the new upstreamed code though, right?

5 years, 5 months ago (2015-07-14 21:23:06 UTC) #2

Shi-Ke Xue

On 2015/07/14 21:23:06, stip wrote: > lgtm. this doesn't use the new upstreamed code though, ...

5 years, 5 months ago (2015-07-14 21:26:26 UTC) #3

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1236243002/1

5 years, 5 months ago (2015-07-14 21:27:12 UTC) #5

commit-bot: I haz the power

5 years, 5 months ago (2015-07-14 21:30:35 UTC) #6

Message was sent while issue was closed.

Committed patchset #1 (id:1) as
https://chromium.googlesource.com/infra/infra/+/7b36f623e12a4b76efb54715dbe96...

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages