Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(306)

Issue 1236183002: Oilpan: Replace Heap::collectGarbage(...) with a helper function (Closed)

Created:
5 years, 5 months ago by haraken
Modified:
5 years, 4 months ago
Reviewers:
keishi
CC:
blink-reviews, haraken, oilpan-reviews, kouhei+heap_chromium.org, Mads Ager (chromium)
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Oilpan: Replace Heap::collectGarbage(...) with a helper function The parameters are too verbose to write every time. BUG= Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=201045

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+180 lines, -170 lines) Patch
M Source/platform/heap/HeapTest.cpp View 1 2 119 chunks +180 lines, -170 lines 0 comments Download

Messages

Total messages: 12 (6 generated)
haraken
PTAL
5 years, 5 months ago (2015-07-14 08:57:01 UTC) #2
keishi
lgtm
5 years, 5 months ago (2015-07-14 09:11:28 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1236183002/20001
5 years, 5 months ago (2015-07-14 12:38:04 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: linux_blink_rel on tryserver.blink (JOB_FAILED, http://build.chromium.org/p/tryserver.blink/builders/linux_blink_rel/builds/71011)
5 years, 5 months ago (2015-07-14 13:13:14 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1236183002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1236183002/40001
5 years, 4 months ago (2015-08-23 23:52:18 UTC) #11
commit-bot: I haz the power
5 years, 4 months ago (2015-08-24 00:45:41 UTC) #12
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=201045

Powered by Google App Engine
This is Rietveld 408576698