Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(310)

Issue 1236173005: Revert of Canvas.toDataURL to use SkBitmap::readPixels to avoid uninitialized memory (Closed)

Created:
5 years, 5 months ago by sof
Modified:
5 years, 5 months ago
CC:
blink-reviews, krit, blink-reviews-html_chromium.org, drott+blinkwatch_chromium.org, dshwang, pdr+graphicswatchlist_chromium.org, jbroman, danakj, dglazkov+blink, Rik, f(malita), Stephen Chennney, rwlbuis
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Revert of Canvas.toDataURL to use SkBitmap::readPixels to avoid uninitialized memory (patchset #4 id:60001 of https://codereview.chromium.org/1234083003/) Reason for revert: ASan bots are failing on toDataURL() tests, http://build.chromium.org/p/chromium.webkit/builders/WebKit%20Linux%20ASAN/builds/19488 http://build.chromium.org/p/chromium.webkit/builders/WebKit%20Linux%20Oilpan%20ASAN/builds/2978 Original issue's description: > Canvas.toDataURL to use SkBitmap::readPixels to avoid uninitialized memory > > This change refactors toDataURL to make it read the canvas data into > a pre-initialized buffer to avoid accessing unitialized memory in cases > where a GPU readback fails silently. > > BUG=504690 > > Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=199131 TBR=senorblanco@chromium.org,junov@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=504690 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=199154

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+30 lines, -34 lines) Patch
M Source/core/html/HTMLCanvasElement.h View 2 chunks +0 lines, -2 lines 0 comments Download
M Source/core/html/HTMLCanvasElement.cpp View 1 chunk +16 lines, -31 lines 0 comments Download
M Source/platform/graphics/ImageBuffer.h View 1 chunk +1 line, -0 lines 0 comments Download
M Source/platform/graphics/ImageBuffer.cpp View 2 chunks +13 lines, -1 line 0 comments Download

Messages

Total messages: 3 (0 generated)
sof
Created Revert of Canvas.toDataURL to use SkBitmap::readPixels to avoid uninitialized memory
5 years, 5 months ago (2015-07-18 06:45:58 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1236173005/1
5 years, 5 months ago (2015-07-18 06:46:08 UTC) #2
commit-bot: I haz the power
5 years, 5 months ago (2015-07-18 06:46:29 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=199154

Powered by Google App Engine
This is Rietveld 408576698