Issue 1236163002: Don't paginate lines that are taller than the column / page.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1236163002: Don't paginate lines that are taller than the column / page. (Closed)

Created:
5 years, 5 months ago by mstensho (USE GERRIT)

Modified:
5 years, 5 months ago

Reviewers:
dsinclair

CC:
blink-reviews, szager+layoutwatch_chromium.org, zoltan1, pdr+renderingwatchlist_chromium.org, eae+blinkwatch, leviw+renderwatch, blink-reviews-rendering, jchaffraix+rendering, mstensho (USE GERRIT)

Base URL:
svn://svn.chromium.org/blink/trunk

Target Ref:
refs/remotes/origin/master

Project:
blink

Visibility:
Public.

More Reviews

Description

Don't paginate lines that are taller than the column / page. This is a partial revert of https://codereview.chromium.org/1221803003 I still believe what that patch did was correct, but it broke printing of Google Docs. BUG=507972 R=dsinclair@chromium.org Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=198866

Patch Set 1 #

Created: 5 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+56 lines, -18 lines)			Patch
D	LayoutTests/fast/multicol/line-too-tall-to-fit.html	View	1 chunk	+0 lines, -10 lines	0 comments	Download
D	LayoutTests/fast/multicol/line-too-tall-to-fit-expected.html	View	1 chunk	+0 lines, -8 lines	0 comments	Download
A	LayoutTests/fast/multicol/tall-line-in-short-block.html	View	1 chunk	+30 lines, -0 lines	0 comments	Download
A	LayoutTests/fast/multicol/tall-line-in-short-block-expected.html	View	1 chunk	+19 lines, -0 lines	0 comments	Download
M	Source/core/layout/LayoutBlockFlow.cpp	View	1 chunk	+7 lines, -0 lines	0 comments	Download

Messages

Total messages: 5 (1 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1236163002/1

5 years, 5 months ago (2015-07-14 13:43:46 UTC) #4

commit-bot: I haz the power

5 years, 5 months ago (2015-07-14 14:53:11 UTC) #5

Message was sent while issue was closed.

Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=198866

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages