Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(184)

Issue 1236143002: Fix big-endian after '[osr] Increase Code::profiler_ticks to 28 bits.' (Closed)

Created:
5 years, 5 months ago by paul.l...
Modified:
5 years, 5 months ago
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Fix big-endian after '[osr] Increase Code::profiler_ticks to 28 bits.' Several users of kKindSpecificFlags1Offset (aliased as kFullCodeFlags) were reading/writing bytes -- not endian agnostic. TEST=mjsunit/debug-setexceptionbreak, mjsunit/debug-mirror-cache, mjsunit/regress/regress-94873, others... BUG= Committed: https://crrev.com/5ce700be8a72432c48d89869db7509d21644ca4d Cr-Commit-Position: refs/heads/master@{#29634}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -12 lines) Patch
M src/objects-inl.h View 1 chunk +12 lines, -12 lines 0 comments Download

Messages

Total messages: 11 (4 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1236143002/1
5 years, 5 months ago (2015-07-14 02:37:58 UTC) #2
paul.l...
PTAL.
5 years, 5 months ago (2015-07-14 02:51:31 UTC) #4
Benedikt Meurer
lgtm
5 years, 5 months ago (2015-07-14 02:52:24 UTC) #5
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 5 months ago (2015-07-14 03:29:53 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1236143002/1
5 years, 5 months ago (2015-07-14 03:33:32 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 5 months ago (2015-07-14 03:34:41 UTC) #10
commit-bot: I haz the power
5 years, 5 months ago (2015-07-14 03:34:57 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/5ce700be8a72432c48d89869db7509d21644ca4d
Cr-Commit-Position: refs/heads/master@{#29634}

Powered by Google App Engine
This is Rietveld 408576698