Add BUILD.gn file to build libpng.

Add BUILD.gn file to build libpng.

This adds the BUILD.gn file so GN can generate the ninja files for this
third_party project.

BUG=None
TEST=gn, ninja -C out/Default libpng
R=brettw@chromium.org

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=244161

[tfarina, 2014-01-06 23:20:40]

https://codereview.chromium.org/123613008/diff/1/tools/gn/secondary/third_par...
File tools/gn/secondary/third_party/libpng/BUILD.gn (right):

https://codereview.chromium.org/123613008/diff/1/tools/gn/secondary/third_par...
tools/gn/secondary/third_party/libpng/BUILD.gn:54: configs +=
"//build/config/compiler:no_chromium_code"
can you make this optional? I found this awkward, compared to gyp. Can't we
assume everything is non chromium code, then have a way to say is_chromium_code
= true?

[brettw, 2014-01-08 05:26:49]

I think you can put your new file in the "real" location in
src/third_party/libpng

https://codereview.chromium.org/123613008/diff/50001/tools/gn/secondary/third...
File tools/gn/secondary/third_party/libpng/BUILD.gn (right):

https://codereview.chromium.org/123613008/diff/50001/tools/gn/secondary/third...
tools/gn/secondary/third_party/libpng/BUILD.gn:56: #'export_dependent_settings':
[
This would turn into:
forward_dependent_configs_from = [ "//third_party/zlib" ]

https://codereview.chromium.org/123613008/diff/50001/tools/gn/secondary/third...
tools/gn/secondary/third_party/libpng/BUILD.gn:65: #if
(component=="shared_library"') {
Substitute component -> component_mode and I think this will work.

https://codereview.chromium.org/123613008/diff/50001/tools/gn/secondary/third...
tools/gn/secondary/third_party/libpng/BUILD.gn:70: #      
'direct_dependent_settings': {
Put this in the config above (in a component mode condition).

https://codereview.chromium.org/123613008/diff/50001/tools/gn/secondary/third...
tools/gn/secondary/third_party/libpng/BUILD.gn:76: #['OS!="win"',
{'product_name': 'png'}],
I'd just delete this.

[tfarina, 2014-01-09 01:18:41]

https://codereview.chromium.org/123613008/diff/50001/tools/gn/secondary/third...
File tools/gn/secondary/third_party/libpng/BUILD.gn (right):

https://codereview.chromium.org/123613008/diff/50001/tools/gn/secondary/third...
tools/gn/secondary/third_party/libpng/BUILD.gn:56: #'export_dependent_settings':
[
On 2014/01/08 05:26:50, brettw wrote:
> This would turn into:
> forward_dependent_configs_from = [ "//third_party/zlib" ]

Done.

https://codereview.chromium.org/123613008/diff/50001/tools/gn/secondary/third...
tools/gn/secondary/third_party/libpng/BUILD.gn:65: #if
(component=="shared_library"') {
On 2014/01/08 05:26:50, brettw wrote:
> Substitute component -> component_mode and I think this will work.

Done.

https://codereview.chromium.org/123613008/diff/50001/tools/gn/secondary/third...
tools/gn/secondary/third_party/libpng/BUILD.gn:70: #      
'direct_dependent_settings': {
On 2014/01/08 05:26:50, brettw wrote:
> Put this in the config above (in a component mode condition).

Done.

https://codereview.chromium.org/123613008/diff/50001/tools/gn/secondary/third...
tools/gn/secondary/third_party/libpng/BUILD.gn:76: #['OS!="win"',
{'product_name': 'png'}],
On 2014/01/08 05:26:50, brettw wrote:
> I'd just delete this.

Done.

[brettw, 2014-01-09 05:23:54]

lgtm

https://codereview.chromium.org/123613008/diff/140001/third_party/libpng/BUIL...
File third_party/libpng/BUILD.gn (right):

https://codereview.chromium.org/123613008/diff/140001/third_party/libpng/BUIL...
third_party/libpng/BUILD.gn:53: defines = [
You can delete these since it's in the config, and direct_dependent_configs also
applies the config to the current target.

https://codereview.chromium.org/123613008/diff/140001/third_party/libpng/BUIL...
third_party/libpng/BUILD.gn:64: if (is_win) {
Same with this whole block.

[tfarina, 2014-01-09 22:58:47]

https://codereview.chromium.org/123613008/diff/140001/third_party/libpng/BUIL...
File third_party/libpng/BUILD.gn (right):

https://codereview.chromium.org/123613008/diff/140001/third_party/libpng/BUIL...
third_party/libpng/BUILD.gn:53: defines = [
On 2014/01/09 05:23:54, brettw wrote:
> You can delete these since it's in the config, and direct_dependent_configs
also
> applies the config to the current target.

Done.

https://codereview.chromium.org/123613008/diff/140001/third_party/libpng/BUIL...
third_party/libpng/BUILD.gn:64: if (is_win) {
On 2014/01/09 05:23:54, brettw wrote:
> Same with this whole block.

Done.

[commit-bot: I haz the power, 2014-01-09 23:21:46]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/tfarina@chromium.org/123613008/240001

[commit-bot: I haz the power, 2014-01-09 23:21:48]

Failed to apply patch for BUILD.gn:
While running patch -p1 --forward --force --no-backup-if-mismatch;
  patching file BUILD.gn
  Hunk #1 FAILED at 32.
  1 out of 1 hunk FAILED -- saving rejects to file BUILD.gn.rej

Patch:       BUILD.gn
Index: BUILD.gn
diff --git a/BUILD.gn b/BUILD.gn
index
2c4ab569eb47cb9209c59d4f54f4b612960380a9..6fd706e1639fcc1283900bf22e029a8c932cf816
100644
--- a/BUILD.gn
+++ b/BUILD.gn
@@ -32,6 +32,7 @@ group("root") {
     "//third_party/icu:icudata",
     "//third_party/leveldatabase",
     "//third_party/zlib",
+    "//third_party/libpng",
     "//third_party/WebKit/Source/weborigin",
     "//skia",
     "//tools/gn",

[commit-bot: I haz the power, 2014-01-09 23:38:07]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/tfarina@chromium.org/123613008/300001

[commit-bot: I haz the power, 2014-01-10 00:35:35]

Retried try job too often on chromium_presubmit for step(s) presubmit
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=chromium_p...

[commit-bot: I haz the power, 2014-01-10 02:50:12]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/tfarina@chromium.org/123613008/300001

[commit-bot: I haz the power, 2014-01-10 06:27:31]

Retried try job too often on win_rel for step(s) browser_tests
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&nu...

[commit-bot: I haz the power, 2014-01-10 12:01:00]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/tfarina@chromium.org/123613008/300001

[commit-bot: I haz the power, 2014-01-10 15:06:51]

Change committed as 244161