Issue 123613005: [Mac] Resolve trybot flakiness: DCHECK fail when deleting GL shader programs.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 123613005: [Mac] Resolve trybot flakiness: DCHECK fail when deleting GL shader programs. (Closed)

Created:
6 years, 11 months ago by miu

Modified:
6 years, 11 months ago

Reviewers:
Alpha Left Google

CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, jam, miu+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

[Mac] Resolve trybot flakiness: DCHECK fail when deleting GL shader programs. The code has other protections to ensure all programs will be eventually deleted, and only once for each time they're created. BUG=326328 R=hclam@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=243196

Created: 6 years, 11 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+0 lines, -2 lines)			Patch
	M	content/browser/renderer_host/compositing_iosurface_shader_programs_mac.cc	View		1 chunk	+0 lines, -2 lines	0 comments	Download

Total messages: 5 (0 generated)

miu

Alpha: PTAL. I believe the flakiness is either due to a GL driver bug or ...

6 years, 11 months ago (2014-01-06 21:14:05 UTC) #1

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/miu@chromium.org/123613005/1

6 years, 11 months ago (2014-01-06 21:29:37 UTC) #3

miu

All Mac trybots passed. Directly committing since this flake is happening too often, slowing down ...

6 years, 11 months ago (2014-01-06 23:14:20 UTC) #4

miu

6 years, 11 months ago (2014-01-06 23:16:10 UTC) #5

Message was sent while issue was closed.

Committed patchset #1 manually as r243196 (presubmit successful).