Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(299)

Issue 1236073002: Added build dependency from events_test_support to events_devices for ozone builds. (Closed)

Created:
5 years, 5 months ago by bruthig
Modified:
5 years, 5 months ago
Reviewers:
sadrul, Adrian Kuegel
CC:
chromium-reviews, jdduke+watch_chromium.org, tdresser+watch_chromium.org, spang, Adrian Kuegel
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Added build dependency from events_test_support to events_devices for ozone builds. BUG=499476 Committed: https://crrev.com/c52bd8a90f48fadf053105b3d7d411daa0e541cd Cr-Commit-Position: refs/heads/master@{#338678}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -11 lines) Patch
M ui/events/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
M ui/events/events.gyp View 2 chunks +4 lines, -11 lines 0 comments Download

Messages

Total messages: 9 (3 generated)
bruthig
Trying to fix the errors on the ChromiumOS Code search bot. https://build.chromium.org/p/chromium.infra.cron/builders/ChromiumOS%20Codesearch/builds/466/steps/compile/logs/stdio I was unable ...
5 years, 5 months ago (2015-07-13 22:56:36 UTC) #2
sadrul
lgtm
5 years, 5 months ago (2015-07-14 08:08:30 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1236073002/1
5 years, 5 months ago (2015-07-14 13:03:51 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 5 months ago (2015-07-14 13:59:20 UTC) #6
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/c52bd8a90f48fadf053105b3d7d411daa0e541cd Cr-Commit-Position: refs/heads/master@{#338678}
5 years, 5 months ago (2015-07-14 14:00:13 UTC) #7
Adrian Kuegel
5 years, 5 months ago (2015-07-15 09:13:26 UTC) #9
Message was sent while issue was closed.
Thanks, this fixed the problem.

Powered by Google App Engine
This is Rietveld 408576698