gpu/command_buffer/service/gles2_cmd_decoder.cc - Issue 1236053003: texture mipmap level is not zero-only in ES 3

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: gpu/command_buffer/service/gles2_cmd_decoder.cc

Issue 1236053003: texture mipmap level is not zero-only in ES 3 (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: code rebase Created 5 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: gpu/command_buffer/service/gles2_cmd_decoder.cc

diff --git a/gpu/command_buffer/service/gles2_cmd_decoder.cc b/gpu/command_buffer/service/gles2_cmd_decoder.cc

index c01034a3b6799113ee3cbbffe4380705d3a09a2e..cc7dc5444b1b1693843552bee260bdec9c4362d5 100644

--- a/gpu/command_buffer/service/gles2_cmd_decoder.cc

+++ b/gpu/command_buffer/service/gles2_cmd_decoder.cc

@@ -6083,7 +6083,8 @@ void GLES2DecoderImpl::DoFramebufferTexture2DCommon(

service_id = texture_ref->service_id();

}

- if (!texture_manager()->ValidForTarget(textarget, level, 0, 0, 1)) {

+ if ((level > 0 && !feature_info_->IsES3Enabled()) ||

+ !texture_manager()->ValidForTarget(textarget, level, 0, 0, 1)) {

LOCAL_SET_GL_ERROR(

GL_INVALID_VALUE,

name, "level out of range");