texture mipmap level is not zero-only in ES 3

gpu/command_buffer/service/texture_manager.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "gpu/command_buffer/service/texture_manager.h"
 
 #include <algorithm>
 #include <set>
 #include <utility>
 
@@ skipping 1418 matching lines @@
       }
     }
   }
 
   *black_texture = ids[0];
   return default_texture;
 }
 
 bool TextureManager::ValidForTarget(
     GLenum target, GLint level, GLsizei width, GLsizei height, GLsizei depth) {
+  if (level > 0 && !feature_info_->IsES3Capable())

[Zhenyao Mo, 2015/07/21 21:25:05]

This is the wrong place for this validation.  We only want to validate level ==
0 in ES2 for glFramebufferTexture2D/Multisample, but ValidForTarget is for
TexImage2D() etc.  So basically you limit level to 0 for all texture related
operations.

The validation should go to GLES2DecoderImpl::DoFramebufferTexture2D().

Also, you should use IsES3Enabled(), not IsES3Capable().  We could still run ES2
context on top of ES3 drivers.

+    return false;
   GLsizei max_size = MaxSizeForTarget(target) >> level;
   return level >= 0 &&
          width >= 0 &&
          height >= 0 &&
          depth >= 0 &&
          level < MaxLevelsForTarget(target) &&
          width <= max_size &&
          height <= max_size &&
          depth <= max_size &&
          (level == 0 || feature_info_->feature_flags().npot_ok ||
@@ skipping 573 matching lines @@
 }
 
 ScopedTextureUploadTimer::~ScopedTextureUploadTimer() {
   texture_state_->texture_upload_count++;
   texture_state_->total_texture_upload_time +=
       base::TimeTicks::Now() - begin_time_;
 }
 
 }  // namespace gles2
 }  // namespace gpu