Issue 1236043004: Improve drawer performance

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1236043004: Improve drawer performance (Closed)

Created:
5 years, 5 months ago by abarth-chromium

Modified:
5 years, 5 months ago

Reviewers:
Hixie, eseidel

CC:
Aaron Boodman, abarth-chromium, ben+mojo_chromium.org, darin (slow to review), gregsimon, jackson_old, mojo-reviews_chromium.org, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org

Base URL:
git@github.com:domokit/mojo.git@master

Target Ref:
refs/heads/master

Project:
mojo

Visibility:
Public.

More Reviews

Description

Improve drawer performance - Instead of using a ColorFilter or an Opacity widget to colorize the Icons, add a ColorFilter parameter it the image classes. This avoids needing to call saveLayer for each DrawerItem. - Ask Android for unbuffered input events to avoid bad synchronization with vsync. R=ianh@google.com Committed: https://chromium.googlesource.com/external/mojo/+/7322ea80649c6d9ff221ff6778f9564624f0d073

Patch Set 1 #

Patch Set 2 : cache paint #

Created: 5 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+84 lines, -29 lines)			Patch
M	sky/sdk/lib/rendering/box.dart	View	1	3 chunks	+25 lines, -3 lines	0 comments	Download
M	sky/sdk/lib/widgets/basic.dart	View		2 chunks	+22 lines, -8 lines	0 comments	Download
M	sky/sdk/lib/widgets/drawer_item.dart	View		1 chunk	+12 lines, -14 lines	0 comments	Download
M	sky/sdk/lib/widgets/icon.dart	View		3 chunks	+12 lines, -2 lines	0 comments	Download
M	sky/services/engine/input_event.mojom	View		1 chunk	+2 lines, -0 lines	0 comments	Download
M	sky/shell/android/org/domokit/sky/shell/PlatformViewAndroid.java	View		2 chunks	+11 lines, -2 lines	0 comments	Download

Messages

Total messages: 5 (1 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

Hixie

lgtm lgtm. in subsequent cls: cache the paint operator== on the color filter

5 years, 5 months ago (2015-07-15 18:06:01 UTC) #2

abarth-chromium

Committed patchset #2 (id:20001) manually as 7322ea80649c6d9ff221ff6778f9564624f0d073 (presubmit successful).

5 years, 5 months ago (2015-07-15 18:07:57 UTC) #3

Message was sent while issue was closed.

lgtm

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages