Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(14)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1236033010: Fix attributes of TypedArray properties (Closed)

Created:
5 years, 5 months ago by Dan Ehrenberg
Modified:
5 years, 5 months ago
Reviewers:
adamk
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Fix attributes of TypedArray properties Some need to be configurable and are currently non-configurable, and vice versa. R=adamk

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -4 lines) Patch
M src/typedarray.js View 1 chunk +5 lines, -4 lines 2 comments Download

Messages

Total messages: 6 (2 generated)
Dan Ehrenberg
5 years, 5 months ago (2015-07-16 19:10:20 UTC) #2
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1236033010/1
5 years, 5 months ago (2015-07-16 19:10:36 UTC) #3
adamk
Please add tests for these changes. https://codereview.chromium.org/1236033010/diff/1/src/typedarray.js File src/typedarray.js (right): https://codereview.chromium.org/1236033010/diff/1/src/typedarray.js#newcode358 src/typedarray.js:358: READ_ONLY | DONT_ENUM ...
5 years, 5 months ago (2015-07-16 19:16:12 UTC) #4
commit-bot: I haz the power
5 years, 5 months ago (2015-07-16 19:18:59 UTC) #6 
Dry run: Try jobs failed on following builders:
  v8_mac_rel on tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_mac_rel/builds/7820)

(exceeded global retry quota)

Powered by Google App Engine
This is Rietveld 408576698