Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(173)

Issue 1236023007: X87: Debugger: use debug break slots to break at function exit. (Closed)

Created:
5 years, 5 months ago by chunyang.dai
Modified:
5 years, 5 months ago
Reviewers:
Weiliang
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

X87: Debugger: use debug break slots to break at function exit. port fc9c5275c3a747caca709b7d5745579f70e61301 (r29672). original commit message: Debugger: use debug break slots to break at function exit. By not having to patch the return sequence (we patch the debug break slot right before it), we don't overwrite it and therefore don't have to keep the original copy of the code around. BUG= Committed: https://crrev.com/1d9216504965ab4f3e88d99b4f07bdbefa305676 Cr-Commit-Position: refs/heads/master@{#29694}

Patch Set 1 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+62 lines, -193 lines) Patch
M src/x87/assembler-x87.h View 3 chunks +5 lines, -18 lines 0 comments Download
M src/x87/assembler-x87.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M src/x87/assembler-x87-inl.h View 6 chunks +15 lines, -51 lines 0 comments Download
M src/x87/debug-x87.cc View 3 chunks +37 lines, -107 lines 0 comments Download
M src/x87/full-codegen-x87.cc View 1 chunk +2 lines, -14 lines 0 comments Download
M src/x87/macro-assembler-x87.h View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 8 (3 generated)
chunyang.dai
PTAL
5 years, 5 months ago (2015-07-16 08:17:14 UTC) #3
Weiliang
lgtm
5 years, 5 months ago (2015-07-16 08:26:17 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1236023007/20001
5 years, 5 months ago (2015-07-16 08:26:22 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:20001)
5 years, 5 months ago (2015-07-16 08:49:39 UTC) #7
commit-bot: I haz the power
5 years, 5 months ago (2015-07-16 08:49:50 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/1d9216504965ab4f3e88d99b4f07bdbefa305676
Cr-Commit-Position: refs/heads/master@{#29694}

Powered by Google App Engine
This is Rietveld 408576698