pkg/analyzer/lib/src/generated/engine.dart - Issue 1236013003: Fixed bug in implicit analysis notification and renamed tests

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: pkg/analyzer/lib/src/generated/engine.dart

Issue 1236013003: Fixed bug in implicit analysis notification and renamed tests (Closed) Base URL: https://github.com/dart-lang/sdk.git@master

Patch Set: Created 5 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: pkg/analyzer/lib/src/generated/engine.dart

diff --git a/pkg/analyzer/lib/src/generated/engine.dart b/pkg/analyzer/lib/src/generated/engine.dart

index 52290d6aea7b8ad32f3b0ecbcd0ef2db6c879151..139edeb41fd10cd3e4bd497d879df300ead9927a 100644

--- a/pkg/analyzer/lib/src/generated/engine.dart

+++ b/pkg/analyzer/lib/src/generated/engine.dart

@@ -4599,7 +4599,7 @@ class AnalysisContextImpl implements InternalAnalysisContext {

void _removeFromCache(Source source) {

SourceEntry entry = _cache.remove(source);

- if (entry != null && entry.explicitlyAdded) {

+ if (entry != null && !entry.explicitlyAdded) {

_implicitAnalysisEventsController

.add(new ImplicitAnalysisEvent(source, false));

}