chrome/browser/download/download_ui_controller_unittest.cc - Issue 1236003005: Move closing-blank-tab logic in Browser class to DownloadUIConttroller

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/download/download_ui_controller_unittest.cc

Issue 1236003005: Move closing-blank-tab logic in Browser class to DownloadUIConttroller (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Addressed comments Created 5 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/browser/download/download_ui_controller_unittest.cc

diff --git a/chrome/browser/download/download_ui_controller_unittest.cc b/chrome/browser/download/download_ui_controller_unittest.cc

index 04fc1f9b8ad7ec47a87f8956b61a103087263b71..64dbdacfcbed37ca8496719cf247fd2f27e3f2c7 100644

--- a/chrome/browser/download/download_ui_controller_unittest.cc

+++ b/chrome/browser/download/download_ui_controller_unittest.cc

@@ -229,6 +229,7 @@ DownloadUIControllerTest::CreateMockInProgressDownload() {

EXPECT_CALL(*item, GetOpened()).WillRepeatedly(Return(false));

EXPECT_CALL(*item, GetMimeType()).WillRepeatedly(Return(std::string()));

EXPECT_CALL(*item, GetURL()).WillRepeatedly(testing::ReturnRefOfCopy(GURL()));

+ EXPECT_CALL(*item, GetWebContents()).WillRepeatedly(Return(nullptr));

EXPECT_CALL(*item, IsTemporary()).WillRepeatedly(Return(false));

return item.Pass();

}

« no previous file with comments | « chrome/browser/download/download_ui_controller.cc ('k') | chrome/browser/ui/browser.h » ('j') | no next file with comments »