Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(72)

Unified Diff: src/compiler/ast-graph-builder.cc

Issue 1235983002: [strong] class objects created in strong mode have their prototype frozen (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Created 5 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/arm64/full-codegen-arm64.cc ('k') | src/full-codegen.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/compiler/ast-graph-builder.cc
diff --git a/src/compiler/ast-graph-builder.cc b/src/compiler/ast-graph-builder.cc
index 99510e3abc8aa69cea2ab7d8d459072640fcea96..493c6365ab95aa13fda1371116bc9671c5bb21e8 100644
--- a/src/compiler/ast-graph-builder.cc
+++ b/src/compiler/ast-graph-builder.cc
@@ -1641,6 +1641,11 @@ void AstGraphBuilder::VisitClassLiteralContents(ClassLiteral* expr) {
NewNode(op, environment()->Pop()); // prototype
NewNode(op, environment()->Pop()); // literal
if (is_strong(language_mode())) {
+ proto =
+ NewNode(javascript()->CallRuntime(Runtime::kObjectFreeze, 1), proto);
+ // Freezing the class prototype should never deopt.
+ PrepareFrameState(proto, BailoutId::None());
+
// TODO(conradw): It would be more efficient to define the properties with
rossberg 2015/07/14 07:45:22 Nit: move this comment before the proto freeze (ap
conradw 2015/07/14 11:21:27 Done.
// the right attributes the first time round.
literal =
« no previous file with comments | « src/arm64/full-codegen-arm64.cc ('k') | src/full-codegen.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698