Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(483)

Unified Diff: pkg/compiler/lib/src/js_emitter/startup_emitter/deferred_fragment_hash.dart

Issue 1235973004: dart2js: Use the correct hashes for deferred code in the startup-emitter. (Closed) Base URL: git@github.com:dart-lang/sdk.git@master
Patch Set: Reupload and probably some minor fixes. Created 5 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: pkg/compiler/lib/src/js_emitter/startup_emitter/deferred_fragment_hash.dart
diff --git a/pkg/compiler/lib/src/js_emitter/full_emitter/deferred_output_unit_hash.dart b/pkg/compiler/lib/src/js_emitter/startup_emitter/deferred_fragment_hash.dart
similarity index 60%
copy from pkg/compiler/lib/src/js_emitter/full_emitter/deferred_output_unit_hash.dart
copy to pkg/compiler/lib/src/js_emitter/startup_emitter/deferred_fragment_hash.dart
index 8c79a8b20635f6d5505170ed3392434b964a0dcb..ddb3fc901f9adf8da355a3c98c0e46e8bd57abf0 100644
--- a/pkg/compiler/lib/src/js_emitter/full_emitter/deferred_output_unit_hash.dart
+++ b/pkg/compiler/lib/src/js_emitter/startup_emitter/deferred_fragment_hash.dart
@@ -2,13 +2,13 @@
// for details. All rights reserved. Use of this source code is governed by a
// BSD-style license that can be found in the LICENSE file.
-part of dart2js.js_emitter.full_emitter;
+part of dart2js.js_emitter.startup_emitter.model_emitter;
-class _DeferredOutputUnitHash extends jsAst.DeferredString {
+class _DeferredFragmentHash extends js.DeferredString {
String _hash;
- final OutputUnit _outputUnit;
+ final DeferredFragment _fragment;
- _DeferredOutputUnitHash(this._outputUnit);
+ _DeferredFragmentHash(this._fragment);
void setHash(String hash) {
Siggi Cherem (dart-lang) 2015/07/23 00:01:10 any reason why not make this `set hash`?
floitsch 2015/07/29 18:00:28 Because this should only happen once as a delibera
assert(_hash == null);
@@ -20,5 +20,5 @@ class _DeferredOutputUnitHash extends jsAst.DeferredString {
return '"$_hash"';
}
- String toString() => "HashCode for ${_outputUnit} [$_hash]";
+ String toString() => "HashCode for ${_fragment} [$_hash]";
}

Powered by Google App Engine
This is Rietveld 408576698