Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(444)

Issue 1235953004: Preserve SKP cullrects on deserialization (Closed)

Created:
5 years, 5 months ago by f(malita)
Modified:
5 years, 5 months ago
Reviewers:
mtklein, reed1
CC:
reviews_skia.org
Base URL:
https://chromium.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Preserve SKP cullrects on deserialization Let's not ignore the offset. R=reed@google.com,mtklein@google.com Committed: https://skia.googlesource.com/skia/+/2ecc0005364fcd07ef8eec62521f4dbcadff675e

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+21 lines, -3 lines) Patch
M src/core/SkPicture.cpp View 1 chunk +1 line, -3 lines 0 comments Download
M tests/PictureTest.cpp View 1 chunk +20 lines, -0 lines 0 comments Download

Messages

Total messages: 9 (3 generated)
f(malita)
5 years, 5 months ago (2015-07-14 20:03:16 UTC) #2
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1235953004/1
5 years, 5 months ago (2015-07-14 20:03:22 UTC) #3
mtklein
lgtm
5 years, 5 months ago (2015-07-14 20:05:47 UTC) #4
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 5 months ago (2015-07-14 20:11:07 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1235953004/1
5 years, 5 months ago (2015-07-14 20:11:47 UTC) #8
commit-bot: I haz the power
5 years, 5 months ago (2015-07-14 20:12:30 UTC) #9
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/2ecc0005364fcd07ef8eec62521f4dbcadff675e

Powered by Google App Engine
This is Rietveld 408576698