Add scavenger events to GC tracer

Add scavenger events to GC tracer

BUG=

Committed: https://crrev.com/e40d453d4ef5b840a8f1562bf5d8e9c8df007c8d
Cr-Commit-Position: refs/heads/master@{#29768}

[Michael Lippautz, 2015-07-15 07:54:30]

mlippautz@chromium.org changed reviewers:
+ hpayer@chromium.org

[Michael Lippautz, 2015-07-15 07:54:30]

PTAL

access to bots seems to be working now

[Hannes Payer (out of office), 2015-07-20 08:50:25]

https://codereview.chromium.org/1235913002/diff/20001/src/heap/gc-tracer.cc
File src/heap/gc-tracer.cc (right):

https://codereview.chromium.org/1235913002/diff/20001/src/heap/gc-tracer.cc#n...
src/heap/gc-tracer.cc:392: PrintIsolate(heap_->isolate(), "[I:%p] %8.0f
gc-trace: ", heap_->isolate(),
why did you delete the ms?

https://codereview.chromium.org/1235913002/diff/20001/src/heap/gc-tracer.cc#n...
src/heap/gc-tracer.cc:413: case Event::MARK_COMPACTOR:
Here we could further distinguish between incremental marking and
non-incremental marking. But that may not be necessary.

https://codereview.chromium.org/1235913002/diff/20001/src/heap/gc-tracer.cc#n...
src/heap/gc-tracer.cc:455: break;
The default case should never happen:
default:
  UNREACHABLE();

https://codereview.chromium.org/1235913002/diff/20001/src/heap/heap.cc
File src/heap/heap.cc (right):

https://codereview.chromium.org/1235913002/diff/20001/src/heap/heap.cc#newcod...
src/heap/heap.cc:1694: ScavengeVisitor scavenge_visitor(this);
This is another interesting event.

https://codereview.chromium.org/1235913002/diff/20001/src/heap/heap.cc#newcod...
src/heap/heap.cc:1707: // Copy objects reachable from the encountered weak
collections list.
This is another interesting event.

https://codereview.chromium.org/1235913002/diff/20001/src/heap/heap.cc#newcod...
src/heap/heap.cc:1723: while (isolate()->global_handles()->IterateObjectGroups(
This is another interesting event.

Let's increase the coverage of the timestamping a bit.

[Michael Lippautz, 2015-07-20 09:34:05]

PTAL, thanks

https://codereview.chromium.org/1235913002/diff/20001/src/heap/gc-tracer.cc
File src/heap/gc-tracer.cc (right):

https://codereview.chromium.org/1235913002/diff/20001/src/heap/gc-tracer.cc#n...
src/heap/gc-tracer.cc:392: PrintIsolate(heap_->isolate(), "[I:%p] %8.0f
gc-trace: ", heap_->isolate(),
On 2015/07/20 08:50:24, Hannes Payer wrote:
> why did you delete the ms?

whoops. reverted to "ms".

https://codereview.chromium.org/1235913002/diff/20001/src/heap/gc-tracer.cc#n...
src/heap/gc-tracer.cc:413: case Event::MARK_COMPACTOR:
On 2015/07/20 08:50:24, Hannes Payer wrote:
> Here we could further distinguish between incremental marking and
> non-incremental marking. But that may not be necessary.

Acknowledged.

https://codereview.chromium.org/1235913002/diff/20001/src/heap/gc-tracer.cc#n...
src/heap/gc-tracer.cc:455: break;
On 2015/07/20 08:50:25, Hannes Payer wrote:
> The default case should never happen:
> default:
>   UNREACHABLE();

Done.

https://codereview.chromium.org/1235913002/diff/20001/src/heap/heap.cc
File src/heap/heap.cc (right):

https://codereview.chromium.org/1235913002/diff/20001/src/heap/heap.cc#newcod...
src/heap/heap.cc:1694: ScavengeVisitor scavenge_visitor(this);
On 2015/07/20 08:50:25, Hannes Payer wrote:
> This is another interesting event.

Done.

https://codereview.chromium.org/1235913002/diff/20001/src/heap/heap.cc#newcod...
src/heap/heap.cc:1707: // Copy objects reachable from the encountered weak
collections list.
On 2015/07/20 08:50:25, Hannes Payer wrote:
> This is another interesting event.

Done.

https://codereview.chromium.org/1235913002/diff/20001/src/heap/heap.cc#newcod...
src/heap/heap.cc:1723: while (isolate()->global_handles()->IterateObjectGroups(
On 2015/07/20 08:50:25, Hannes Payer wrote:
> This is another interesting event.
> 
> Let's increase the coverage of the timestamping a bit.

Done.

[Hannes Payer (out of office), 2015-07-20 12:02:23]

https://codereview.chromium.org/1235913002/diff/60001/src/heap/heap.cc
File src/heap/heap.cc (right):

https://codereview.chromium.org/1235913002/diff/60001/src/heap/heap.cc#newcod...
src/heap/heap.cc:1719: MarkCompactCollector* collector =
mark_compact_collector();
For completeness, let's also add a timer scope there.

https://codereview.chromium.org/1235913002/diff/60001/src/heap/heap.cc#newcod...
src/heap/heap.cc:1731: GCTracer::Scope gc_scope(tracer(),
move this one outside the while loop and also scope 
isolate()->global_handles()->RemoveObjectGroups();
isolate()->global_handles()->RemoveImplicitRefGroups();

[Michael Lippautz, 2015-07-20 13:17:15]

https://codereview.chromium.org/1235913002/diff/60001/src/heap/heap.cc
File src/heap/heap.cc (right):

https://codereview.chromium.org/1235913002/diff/60001/src/heap/heap.cc#newcod...
src/heap/heap.cc:1719: MarkCompactCollector* collector =
mark_compact_collector();
On 2015/07/20 12:02:23, Hannes Payer wrote:
> For completeness, let's also add a timer scope there.

Done.

https://codereview.chromium.org/1235913002/diff/60001/src/heap/heap.cc#newcod...
src/heap/heap.cc:1731: GCTracer::Scope gc_scope(tracer(),
On 2015/07/20 12:02:23, Hannes Payer wrote:
> move this one outside the while loop and also scope 
> isolate()->global_handles()->RemoveObjectGroups();
> isolate()->global_handles()->RemoveImplicitRefGroups();

Done.

[Hannes Payer (out of office), 2015-07-21 06:45:04]

lgtm

[Michael Lippautz, 2015-07-21 06:58:27]

The CQ bit was checked by mlippautz@chromium.org

[commit-bot: I haz the power, 2015-07-21 06:58:39]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1235913002/80001

[commit-bot: I haz the power, 2015-07-21 07:31:33]

Committed patchset #5 (id:80001)

[commit-bot: I haz the power, 2015-07-21 07:31:51]

Patchset 5 (id:??) landed as
https://crrev.com/e40d453d4ef5b840a8f1562bf5d8e9c8df007c8d
Cr-Commit-Position: refs/heads/master@{#29768}