Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(941)

Unified Diff: content/browser/manifest/manifest_manager_host.cc

Issue 1235883007: manifest: add theme_color value to the manifest (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Add comments Created 5 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | content/common/manifest_manager_messages.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/browser/manifest/manifest_manager_host.cc
diff --git a/content/browser/manifest/manifest_manager_host.cc b/content/browser/manifest/manifest_manager_host.cc
index c22ae0ad46acfd1a4fd4c91c958e3325b55ce4e9..a978f70295b859da87c36cf55f8bba2703228256 100644
--- a/content/browser/manifest/manifest_manager_host.cc
+++ b/content/browser/manifest/manifest_manager_host.cc
@@ -136,6 +136,11 @@ void ManifestManagerHost::OnRequestManifestResponse(
0, Manifest::kMaxIPCStringLength),
related_application.id.is_null());
}
+ // theme_color is a 32 bit unsigned integer with a 64 bit integer simply
+ // being used to encode an error occuring. Therefore, any value outside the
+ // range of an unsigned 32 bit integer is invalid.
+ if (manifest.theme_color < 0 || manifest.theme_color > 0xFFFFFFFF)
+ manifest.theme_color = Manifest::kInvalidOrMissingThemeColor;
callback->Run(manifest);
callbacks->Remove(request_id);
« no previous file with comments | « no previous file | content/common/manifest_manager_messages.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698