Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2358)

Unified Diff: content/browser/manifest/manifest_manager_host.cc

Issue 1235883007: manifest: add theme_color value to the manifest (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fix nasko's comments Created 5 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | content/common/manifest_manager_messages.h » ('j') | content/public/common/manifest.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/browser/manifest/manifest_manager_host.cc
diff --git a/content/browser/manifest/manifest_manager_host.cc b/content/browser/manifest/manifest_manager_host.cc
index c22ae0ad46acfd1a4fd4c91c958e3325b55ce4e9..4d3778b6b2c2f64a80c86c0adc4430f5227504c3 100644
--- a/content/browser/manifest/manifest_manager_host.cc
+++ b/content/browser/manifest/manifest_manager_host.cc
@@ -10,6 +10,7 @@
#include "content/public/browser/render_process_host.h"
#include "content/public/common/manifest.h"
#include "content/public/common/result_codes.h"
+#include "third_party/skia/include/core/SkColor.h"
namespace content {
@@ -136,6 +137,9 @@ void ManifestManagerHost::OnRequestManifestResponse(
0, Manifest::kMaxIPCStringLength),
related_application.id.is_null());
}
+ if (manifest.theme_color < SK_ColorBLACK
+ || manifest.theme_color > SK_ColorWHITE)
nasko 2015/07/20 11:07:03 Need {} around the body of the if statement, as it
+ manifest.theme_color = Manifest::kInvalidOrMissingThemeColor;
callback->Run(manifest);
callbacks->Remove(request_id);
« no previous file with comments | « no previous file | content/common/manifest_manager_messages.h » ('j') | content/public/common/manifest.h » ('J')

Powered by Google App Engine
This is Rietveld 408576698