Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
1235883006:
Update clang package. (Closed)
|
Created:
5 years, 5 months ago by Nico Modified:
5 years, 5 months ago Reviewers:
hans CC:
chromium-reviews, eugenis+clang_chromium.org, glider+clang_chromium.org, dmikurube+clang_chromium.org, ukai+watch_chromium.org Base URL:
https://chromium.googlesource.com/chromium/src.git@master Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
DescriptionUpdate clang package.
The clang revision is the same, the only difference is that the package now
includes a 32-bit asan runtime again. This is a follow-up to
https://codereview.chromium.org/1229653005/
BUG=none
Committed: https://crrev.com/df27bcaebcec778def0b3f94b15349715203b0e8
Cr-Commit-Position: refs/heads/master@{#338549}
Patch Set 1 #
Messages
Total messages: 16 (4 generated)
thakis@chromium.org changed reviewers: + hans@chromium.org
The CQ bit was checked by thakis@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1235883006/1
The CQ bit was unchecked by commit-bot@chromium.org
No L-G-T-M from a valid reviewer yet. Only full committers are accepted. Even if an L-G-T-M may have been provided, it was from a non-committer, _not_ a full super star committer. See http://www.chromium.org/getting-involved/become-a-committer Note that this has nothing to do with OWNERS files.
lgtm
The CQ bit was checked by thakis@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1235883006/1
Message was sent while issue was closed.
Committed patchset #1 (id:1)
Message was sent while issue was closed.
Patchset 1 (id:??) landed as https://crrev.com/df27bcaebcec778def0b3f94b15349715203b0e8 Cr-Commit-Position: refs/heads/master@{#338549}
Message was sent while issue was closed.
Will this solve the following issue we had when trying to roll the last clang? http://build.chromium.org/p/client.v8/builders/V8%20Linux%20ASAN%20mipsel%20-...
Message was sent while issue was closed.
This one should've been fixed by package version 2 already I thought (ie the version that landed). Maybe that goma cell didn't have the new package yet? (I don't land these until goma send me the "your binary is now in all data centers" email though. So no idea, really, but this package likely doesn't affect that problem.) On Jul 13, 2015 12:49 PM, <machenbach@chromium.org> wrote: > Will this solve the following issue we had when trying to roll the last > clang? > > http://build.chromium.org/p/client.v8/builders/V8%20Linux%20ASAN%20mipsel%20-... > > https://codereview.chromium.org/1235883006/ > To unsubscribe from this group and stop receiving emails from it, send an email to chromium-reviews+unsubscribe@chromium.org.
Message was sent while issue was closed.
Now MSan says that libc++ is gone: http://build.chromium.org/p/chromium.memory.fyi/builders/Linux%20ChromeOS%20M...
Message was sent while issue was closed.
On 2015/07/14 18:38:34, eugenis wrote: > Now MSan says that libc++ is gone: > http://build.chromium.org/p/chromium.memory.fyi/builders/Linux%20ChromeOS%20M... That's unrelated, sorry.
Message was sent while issue was closed.
On 2015/07/14 18:47:08, eugenis wrote: > On 2015/07/14 18:38:34, eugenis wrote: > > Now MSan says that libc++ is gone: > > > http://build.chromium.org/p/chromium.memory.fyi/builders/Linux%20ChromeOS%20M... > > That's unrelated, sorry. (I think we never bundled libc++ with clang on Linux. From your follow-up, it sounds like that's what you expect too – but I'm not 100% sure, so sending this reply) |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
