Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3)

Issue 1235883004: MIPS64: Fix BlockTrampolinePoolFor() to emit trampoline before blocking, if needed. (Closed)

Created:
5 years, 5 months ago by balazs.kilvady
Modified:
5 years, 5 months ago
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

MIPS64: Fix BlockTrampolinePoolFor() to emit trampoline before blocking, if needed. Port f0d1106a3fa1ffaa822efc90d61e2aca315cbe15 Fixes possible failure in AssembleArchTableSwitch(). BUG=v8:4294 LOG=y Committed: https://crrev.com/48995988a996f278887d70bb5d90c58a4ccfe2cd Cr-Commit-Position: refs/heads/master@{#29621}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+96 lines, -3 lines) Patch
M src/mips64/assembler-mips64.h View 1 chunk +1 line, -1 line 0 comments Download
M src/mips64/assembler-mips64.cc View 1 chunk +1 line, -0 lines 0 comments Download
M src/mips64/assembler-mips64-inl.h View 1 chunk +2 lines, -2 lines 0 comments Download
M test/cctest/test-assembler-mips64.cc View 3 chunks +3 lines, -0 lines 0 comments Download
M test/cctest/test-macro-assembler-mips64.cc View 3 chunks +89 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
balazs.kilvady
5 years, 5 months ago (2015-07-13 17:15:27 UTC) #2
paul.l...
LGTM.
5 years, 5 months ago (2015-07-13 17:59:11 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1235883004/1
5 years, 5 months ago (2015-07-13 18:00:25 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 5 months ago (2015-07-13 18:26:23 UTC) #6
commit-bot: I haz the power
5 years, 5 months ago (2015-07-13 18:26:45 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/48995988a996f278887d70bb5d90c58a4ccfe2cd
Cr-Commit-Position: refs/heads/master@{#29621}

Powered by Google App Engine
This is Rietveld 408576698