Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(117)

Issue 1235883002: [strong] Strong classes can't extend null (Closed)

Created:
5 years, 5 months ago by conradw
Modified:
5 years, 5 months ago
Reviewers:
rossberg
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[strong] Strong classes can't extend null BUG=v8:3956 LOG=N Committed: https://crrev.com/2f981db039200a066f20ec98e2695c23f4c48c1e Cr-Commit-Position: refs/heads/master@{#29606}

Patch Set 1 #

Total comments: 2

Patch Set 2 : cl feedback #

Unified diffs Side-by-side diffs Delta from patch set Stats (+185 lines, -36 lines) Patch
M src/compiler/ast-graph-builder.cc View 1 chunk +4 lines, -1 line 0 comments Download
M src/full-codegen.cc View 1 chunk +3 lines, -1 line 0 comments Download
M src/messages.h View 1 chunk +1 line, -0 lines 0 comments Download
M src/runtime/runtime.h View 1 chunk +1 line, -0 lines 0 comments Download
M src/runtime/runtime-classes.cc View 3 chunks +79 lines, -34 lines 0 comments Download
A test/mjsunit/strong/class-extend-null.js View 1 1 chunk +97 lines, -0 lines 0 comments Download

Messages

Total messages: 9 (3 generated)
conradw
PTAL
5 years, 5 months ago (2015-07-13 11:31:47 UTC) #2
rossberg
LGTM module 1 test https://codereview.chromium.org/1235883002/diff/1/test/mjsunit/strong/class-extend-null.js File test/mjsunit/strong/class-extend-null.js (right): https://codereview.chromium.org/1235883002/diff/1/test/mjsunit/strong/class-extend-null.js#newcode67 test/mjsunit/strong/class-extend-null.js:67: class Class1 extends null { ...
5 years, 5 months ago (2015-07-13 11:38:38 UTC) #3
conradw
https://codereview.chromium.org/1235883002/diff/1/test/mjsunit/strong/class-extend-null.js File test/mjsunit/strong/class-extend-null.js (right): https://codereview.chromium.org/1235883002/diff/1/test/mjsunit/strong/class-extend-null.js#newcode67 test/mjsunit/strong/class-extend-null.js:67: class Class1 extends null { On 2015/07/13 11:38:38, rossberg ...
5 years, 5 months ago (2015-07-13 11:41:00 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1235883002/20001
5 years, 5 months ago (2015-07-13 11:49:10 UTC) #7
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 5 months ago (2015-07-13 12:40:25 UTC) #8
commit-bot: I haz the power
5 years, 5 months ago (2015-07-13 12:40:48 UTC) #9
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/2f981db039200a066f20ec98e2695c23f4c48c1e
Cr-Commit-Position: refs/heads/master@{#29606}

Powered by Google App Engine
This is Rietveld 408576698