Issue 1235863005: M44 cherry pick of: Added check for ill-conditioned invert

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1235863005: M44 cherry pick of: Added check for ill-conditioned invert (Closed)

Created:
5 years, 5 months ago by robertphillips

Modified:
5 years, 5 months ago

Reviewers:
bsalomon, reed1

CC:
reviews_skia.org

Base URL:
https://skia.googlesource.com/skia.git@m44

Target Ref:
refs/heads/chrome/m44

Project:
skia

Visibility:
Public.

M44 cherry pick of: Added check for ill-conditioned invert sk_inv_determinant has a guard that the determinant can't get too big so this CL only checks if the determinant gets too small. BUG=492263 Review URL: https://codereview.chromium.org/1188433011 NOTREECHECKS=true NOTRY=true NOPRESUBMIT=true TBR=bsalomon@google.com, reed@google.com Committed: https://skia.googlesource.com/skia/+/1c7bee66e0c3fd4fdbe021f34364786e18f94d6d

Created: 5 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+72 lines, -36 lines)			Patch
M	include/core/SkMatrix.h	View	1 chunk	+6 lines, -0 lines	0 comments	Download
M	src/core/SkMatrix.cpp	View	3 chunks	+59 lines, -36 lines	0 comments	Download
M	tests/MatrixTest.cpp	View	1 chunk	+7 lines, -0 lines	0 comments	Download

Total messages: 3 (2 generated)

robertphillips

5 years, 5 months ago (2015-07-13 21:23:39 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
1c7bee66e0c3fd4fdbe021f34364786e18f94d6d.