Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(57)

Issue 1235823002: X87: Reland: Add unoptimized/optimized variants of MathFloor TF code stub (Closed)

Created:
5 years, 5 months ago by chunyang.dai
Modified:
5 years, 5 months ago
Reviewers:
Weiliang
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

X87: Reland: Add unoptimized/optimized variants of MathFloor TF code stub port 737b8573f80deaa1cbaec98f42ecd3e3b56ba901 (r29539) original commit message: - Add a TurboFanIC class, derived from TurboFanCodeStub, that automatically distinguishes between versions of the IC called from optimized and unoptimized code. - Add appropriate InterfaceDescriptors for both the versions of the stub called from unoptimized and optimized code - Change the MathFloor TF stub generator to output either the for-optimized or for-unoptimized version based on the minor_key parameter. BUG= Committed: https://crrev.com/1b20d50594c5f0ca7097fca9299a36fe89338df5 Cr-Commit-Position: refs/heads/master@{#29628}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -2 lines) Patch
M src/x87/interface-descriptors-x87.cc View 1 chunk +13 lines, -2 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
chunyang.dai
PTAL
5 years, 5 months ago (2015-07-14 01:52:08 UTC) #2
Weiliang
lgtm
5 years, 5 months ago (2015-07-14 02:02:32 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1235823002/1
5 years, 5 months ago (2015-07-14 02:02:41 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 5 months ago (2015-07-14 02:28:43 UTC) #6
commit-bot: I haz the power
5 years, 5 months ago (2015-07-14 02:28:57 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/1b20d50594c5f0ca7097fca9299a36fe89338df5
Cr-Commit-Position: refs/heads/master@{#29628}

Powered by Google App Engine
This is Rietveld 408576698