Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(894)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: media/base/media_log.cc

Issue 1235793005: Deprecate LogCB in favor of using MediaLog (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Remove the accidentally included pieces of followup CL Created 5 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « media/base/media_log.h ('k') | media/base/stream_parser.h » ('j') | media/formats/webm/webm_cluster_parser_unittest.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: media/base/media_log.cc
diff --git a/media/base/media_log.cc b/media/base/media_log.cc
index f5f58de73f47c8a2320fa8a91c067d8c26dc2f98..3ef46e1358a2e38bc25ad397a5ab9773640e312a 100644
--- a/media/base/media_log.cc
+++ b/media/base/media_log.cc
@@ -271,19 +271,13 @@ void MediaLog::SetTimeProperty(
AddEvent(event.Pass());
}
-LogHelper::LogHelper(MediaLog::MediaLogLevel level, const LogCB& log_cb)
- : level_(level), log_cb_(log_cb) {
-}
-
LogHelper::LogHelper(MediaLog::MediaLogLevel level,
const scoped_refptr<MediaLog>& media_log)
: level_(level), media_log_(media_log) {
xhwang 2015/07/13 22:41:17 DCHECK media_log so that you don't need the check
wolenetz 2015/07/13 22:59:24 Done.
}
LogHelper::~LogHelper() {
- if (!log_cb_.is_null())
- log_cb_.Run(level_, stream_.str());
- else if (media_log_)
+ if (media_log_)
media_log_->AddLogEvent(level_, stream_.str());
}
« no previous file with comments | « media/base/media_log.h ('k') | media/base/stream_parser.h » ('j') | media/formats/webm/webm_cluster_parser_unittest.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698