Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1194)

Unified Diff: media/filters/source_buffer_stream.h

Issue 1235793005: Deprecate LogCB in favor of using MediaLog (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: media/filters/source_buffer_stream.h
diff --git a/media/filters/source_buffer_stream.h b/media/filters/source_buffer_stream.h
index afef6f74202dc025ad202083a4a2dcca842c3d22..0a9ae97591a6143dcd71cd883af7fda69e1943e6 100644
--- a/media/filters/source_buffer_stream.h
+++ b/media/filters/source_buffer_stream.h
@@ -54,13 +54,13 @@ class MEDIA_EXPORT SourceBufferStream {
};
SourceBufferStream(const AudioDecoderConfig& audio_config,
- const LogCB& log_cb,
+ const scoped_refptr<MediaLog>& media_log,
bool splice_frames_enabled);
SourceBufferStream(const VideoDecoderConfig& video_config,
- const LogCB& log_cb,
+ const scoped_refptr<MediaLog>& media_log,
bool splice_frames_enabled);
SourceBufferStream(const TextTrackConfig& text_config,
- const LogCB& log_cb,
+ const scoped_refptr<MediaLog>& media_log,
bool splice_frames_enabled);
~SourceBufferStream();
@@ -328,9 +328,9 @@ class MEDIA_EXPORT SourceBufferStream {
// appropriately and returns true. Otherwise returns false.
bool SetPendingBuffer(scoped_refptr<StreamParserBuffer>* out_buffer);
- // Callback used to report log messages that can help the web developer figure
- // out what is wrong with the content.
- LogCB log_cb_;
+ // Used to report log messages that can help the web developer figure out what
+ // is wrong with the content.
+ scoped_refptr<MediaLog> media_log_;
// List of disjoint buffered ranges, ordered by start time.
RangeList ranges_;
@@ -419,6 +419,14 @@ class MEDIA_EXPORT SourceBufferStream {
// Indicates that splice frame generation is enabled.
const bool splice_frames_enabled_;
+ // Fields supporting statistics reporting for audio splice frame generation.
wolenetz 2015/07/13 22:25:29 Oops! These were from a CL I'll send later that de
+ // TODO(wolenetz,chcunningham): Once multi-track audio is enabled, report
+ // these statistics to chrome://media-internals per track.
+ int audio_splice_count_;
+ double total_audio_splice_duration_;
+ double min_audio_splice_duration_;
+ double max_audio_splice_duration_;
+
DISALLOW_COPY_AND_ASSIGN(SourceBufferStream);
};

Powered by Google App Engine
This is Rietveld 408576698