Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(883)

Issue 1235763002: Convert mojo_common_unittests to run exclusively on Swarming (Closed)

Created:
5 years, 5 months ago by M-A Ruel
Modified:
5 years, 5 months ago
Reviewers:
jam
CC:
chromium-reviews, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org
Base URL:
https://chromium.googlesource.com/a/chromium/src.git@1_clang
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Convert mojo_common_unittests to run exclusively on Swarming 0 configs already ran on Swarming 18 used to run locally and were converted: - chromium.fyi.json: Linux Trusty - chromium.fyi.json: Linux Trusty (dbg) - chromium.linux.json: Android GN - chromium.linux.json: Linux Tests - chromium.linux.json: Linux Tests (dbg)(1) - chromium.linux.json: Linux Tests (dbg)(1)(32) - chromium.mac.json: Mac10.10 Tests - chromium.mac.json: Mac10.6 Tests - chromium.mac.json: Mac10.8 Tests - chromium.mac.json: Mac10.9 Tests - chromium.mac.json: Mac10.9 Tests (dbg) - chromium.memory.fyi.json: Linux ChromeOS MSan Tests - chromium.memory.fyi.json: Linux MSan Tests - chromium.memory.fyi.json: Linux TSan Tests - chromium.win.json: Vista Tests (1) - chromium.win.json: Win 7 Tests x64 (1) - chromium.win.json: Win7 Tests (1) - chromium.win.json: Win7 Tests (dbg)(1) Ran: ./manage.py --convert mojo_common_unittests R=jam@chromium.org BUG=98637 Committed: https://crrev.com/194f4c6bea6ae714cfa6a0eb32bf7e79a70e0192 Cr-Commit-Position: refs/heads/master@{#338558}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+76 lines, -9 lines) Patch
M mojo/mojo_base.gyp View 1 chunk +19 lines, -2 lines 0 comments Download
A + mojo/mojo_common_unittests.isolate View 2 chunks +3 lines, -7 lines 0 comments Download
M testing/buildbot/chromium.fyi.json View 2 chunks +6 lines, -0 lines 0 comments Download
M testing/buildbot/chromium.linux.json View 4 chunks +12 lines, -0 lines 0 comments Download
M testing/buildbot/chromium.mac.json View 5 chunks +15 lines, -0 lines 0 comments Download
M testing/buildbot/chromium.memory.fyi.json View 3 chunks +9 lines, -0 lines 0 comments Download
M testing/buildbot/chromium.win.json View 4 chunks +12 lines, -0 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 9 (2 generated)
M-A Ruel
5 years, 5 months ago (2015-07-11 21:44:24 UTC) #1
M-A Ruel
sky -> jam There's 11 tests to isolate in total.
5 years, 5 months ago (2015-07-13 15:02:59 UTC) #3
jam
lgtm
5 years, 5 months ago (2015-07-13 15:50:03 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1235763002/1
5 years, 5 months ago (2015-07-13 18:37:17 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 5 months ago (2015-07-13 20:39:40 UTC) #7
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/194f4c6bea6ae714cfa6a0eb32bf7e79a70e0192 Cr-Commit-Position: refs/heads/master@{#338558}
5 years, 5 months ago (2015-07-13 20:40:37 UTC) #8
eugenis
5 years, 5 months ago (2015-07-14 18:49:36 UTC) #9
Message was sent while issue was closed.
Hi,

this broke the MSan bot:

http://build.chromium.org/p/chromium.memory.fyi/builders/Linux%20ChromeOS%20M...

../out/Release/mojo_common_unittests: error while loading shared libraries:
libc++.so: cannot open shared object file: No such file or directory

MSan uses libc++ on Linux, unlike the normal build. Do you need to do anything
special to link libc++ on swarming?

Powered by Google App Engine
This is Rietveld 408576698