Issue 1235713002: Support getting baseline from paint as well as layout.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1235713002: Support getting baseline from paint as well as layout. (Closed)

Created:
5 years, 5 months ago by Hixie

Modified:
5 years, 5 months ago

Reviewers:
abarth-chromium

CC:
abarth-chromium, gregsimon, jackson_old, mojo-reviews_chromium.org, qsr+mojo_chromium.org

Base URL:
https://github.com/domokit/mojo.git@master

Target Ref:
refs/heads/master

Project:
mojo

Visibility:
Public.

Support getting baseline from paint as well as layout. To make sure this doesn't break the markNeedsLayout() logic, I added members to track who is currently painting. Also, some minor rearrangements of the code in object.dart about painting. Also, make exceptions in debug mode rethrow so we get a stack trace. R=abarth@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/93b1ceac71c4caf2092307365a3701fcea97b701

Created: 5 years, 5 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+34 lines, -12 lines)			Patch
	M	sky/sdk/lib/rendering/box.dart	View		1 chunk	+9 lines, -4 lines	0 comments	Download
	M	sky/sdk/lib/rendering/object.dart	View		7 chunks	+25 lines, -8 lines	0 comments	Download

Total messages: 3 (1 generated)

Hixie

5 years, 5 months ago (2015-07-10 22:25:59 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
93b1ceac71c4caf2092307365a3701fcea97b701 (presubmit successful).