Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(130)

Issue 1235693002: Make back button on stocks app search bar the accent color (Closed)

Created:
5 years, 5 months ago by jackson
Modified:
5 years, 5 months ago
Reviewers:
abarth, abarth-chromium
CC:
abarth-chromium, gregsimon, jackson_old, mojo-reviews_chromium.org, qsr+mojo_chromium.org
Base URL:
git@github.com:domokit/mojo.git@master
Target Ref:
refs/heads/master
Project:
mojo
Visibility:
Public.

Description

Make back button on stocks app search bar the accent color. Also, apply text theme to the the entire toolbar rather than just the center. R=abarth@chromium.org, abarth Committed: https://chromium.googlesource.com/external/mojo/+/cc8cc7da56bb598cbad34b5d16beb75d3e5d578f

Patch Set 1 #

Patch Set 2 : remove file #

Patch Set 3 : move color filter stuff into icon_button #

Patch Set 4 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+30 lines, -13 lines) Patch
M sky/sdk/example/stocks/lib/stock_home.dart View 1 2 1 chunk +5 lines, -2 lines 0 comments Download
M sky/sdk/lib/widgets/icon_button.dart View 1 2 2 chunks +13 lines, -2 lines 0 comments Download
M sky/sdk/lib/widgets/tool_bar.dart View 1 2 3 4 chunks +12 lines, -9 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
abarth-chromium
lgtm
5 years, 5 months ago (2015-07-10 20:58:24 UTC) #2
jackson
I moved the ColorFilter stuff into IconButton
5 years, 5 months ago (2015-07-10 21:06:01 UTC) #3
jackson
5 years, 5 months ago (2015-07-10 21:34:56 UTC) #4
Message was sent while issue was closed.
Committed patchset #4 (id:60001) manually as
cc8cc7da56bb598cbad34b5d16beb75d3e5d578f (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698