Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(540)

Issue 1235673004: Fix support for mojo_common_unittests on MSan. (Closed)

Created:
5 years, 5 months ago by M-A Ruel
Modified:
5 years, 5 months ago
Reviewers:
jam, eugenis
CC:
chromium-reviews, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org, eugenis
Base URL:
https://chromium.googlesource.com/a/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix support for mojo_common_unittests on MSan. This broke in 194f4c6bea6ae714cfa6a0eb32bf7e79a70e0192. MSan uses libc++ on Linux, unlike the normal build, so libc++.so must be mapped. It is mapped as part of base.isolate. R=jam@chromium.org BUG=98637 Committed: https://crrev.com/6fdafbf5e1ca5fbe4e9357c25978906453557225 Cr-Commit-Position: refs/heads/master@{#338760}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M mojo/mojo_common_unittests.isolate View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 8 (2 generated)
M-A Ruel
5 years, 5 months ago (2015-07-14 19:53:09 UTC) #1
eugenis
lgtm
5 years, 5 months ago (2015-07-14 19:56:25 UTC) #3
jam
lgtm
5 years, 5 months ago (2015-07-14 20:20:10 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1235673004/1
5 years, 5 months ago (2015-07-14 20:51:37 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 5 months ago (2015-07-14 22:39:12 UTC) #7
commit-bot: I haz the power
5 years, 5 months ago (2015-07-14 22:40:33 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/6fdafbf5e1ca5fbe4e9357c25978906453557225
Cr-Commit-Position: refs/heads/master@{#338760}

Powered by Google App Engine
This is Rietveld 408576698